From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbcCGOaq (ORCPT ); Mon, 7 Mar 2016 09:30:46 -0500 Received: from lists.s-osg.org ([54.187.51.154]:36727 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752891AbcCGOaj (ORCPT ); Mon, 7 Mar 2016 09:30:39 -0500 Subject: Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic To: Sylwester Nawrocki , Krzysztof Kozlowski References: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> <56DD48C1.8010004@samsung.com> From: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , Mauro Carvalho Chehab , linux-samsung-soc@vger.kernel.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Message-ID: <56DD9086.7070903@osg.samsung.com> Date: Mon, 7 Mar 2016 11:30:30 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56DD48C1.8010004@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sylwester, On 03/07/2016 06:24 AM, Sylwester Nawrocki wrote: > Hi Javier, Krzysztof, > > On 03/05/2016 05:35 AM, Krzysztof Kozlowski wrote: >> 2016-03-05 5:20 GMT+09:00 Javier Martinez Canillas : >>>> Hello, >>>> >>>> This series have two trivial fixes for issues that I noticed while >>>> reading as a reference the driver's functions that parse the graph >>>> port and endpoints nodes. >>>> >>>> It was only compile tested because I don't have access to a Exynos4 >>>> hardware to test the DT parsing, but the patches are very simple. >> >> Not directly related, but similar: my previous two patches for missing >> of_node_put [0] are unfortunately still waiting. Although I have >> Exynos4 boards, but I don't have infrastructure/scripts to test it. >> >> Best regards, >> Krzysztof >> I've reviewed Krzysztof and looks good to me. >> [0] https://patchwork.linuxtv.org/patch/32707/ > > Thanks for the patches, I've delegated them to myself and I'm going to > review/apply them this week. > Thanks, I just noticed another similar issue in the driver now and is that fimc_is_parse_sensor_config() uses the same struct device_node * for looking up the I2C sensor, port and endpoint and thus not doing a of_node_put() for all the nodes on the error path. I think the right fix is to have a separate struct device_node * for each so their reference counter cand be incremented and decremented. > -- > Regards, > Sylwester > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America