From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541AbcCHPry (ORCPT ); Tue, 8 Mar 2016 10:47:54 -0500 Received: from mail-bn1bon0064.outbound.protection.outlook.com ([157.56.111.64]:59522 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750773AbcCHPrn (ORCPT ); Tue, 8 Mar 2016 10:47:43 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; arm.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;arm.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=opensource.altera.com; Reply-To: Subject: Re: [PATCHv2 07/11] EDAC, altera: Add status offset & masks References: <1457379787-8327-1-git-send-email-tthayer@opensource.altera.com> <1457379787-8327-8-git-send-email-tthayer@opensource.altera.com> To: , , , , , , , , , , CC: , , , , , From: Thor Thayer Message-ID: <56DEF52B.9000801@opensource.altera.com> Date: Tue, 8 Mar 2016 09:52:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457379787-8327-8-git-send-email-tthayer@opensource.altera.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR0401CA0030.namprd04.prod.outlook.com (25.162.114.168) To BN3PR03MB1480.namprd03.prod.outlook.com (25.163.35.143) X-MS-Office365-Filtering-Correlation-Id: cf66942e-82ce-4dcd-1f96-08d34768faf1 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;2:IjMCCQwmICrW5ExYby5u32tWfJrrSsGE9weS0AKx8m9h3TkLnscQ2VJz8ACu8AfVK/+Lp7ctheZIG9DMf2OCe/o3sKmyHms3NjHCo5Ei0gHxcd76pma9I478uwyUIGQeKJVs4M58aOrh4n3P/dDw1RwTC5g306E6raxlDwZ1ACv38r1xxExzfbQv8QDhpUCy;3:NOQWRw5fji9C/bBX/3BB6YahdWYPeJbJjOEpuutc0OY/4w9pDiL0VaftlvLG1xsfaOfZnwDXxxsdyxsQcfb2Cx7+rNjZdPAMJqsZHxGzbf8z0eV+MT7O6lX4RjSlZCXh;25:3N4VNZ+UfgAdvAp1L22n0gcuFEqMd8NjMcrARO3PH4705GHBUEZSpUc3j/UQwrOr4dN7SqkPTnqEYh56ET5ssbHTyJyDkFGmKTCbssWUWVuzjkKKBYNTyVG4gz4Y7zciZiwih82BOICKft5MDLIbeTyiRxdD4/R+DgDDarSJhroYE7aqok6fw5sQypu5EAcAo0BK5l3JLISjTj4K/nJlKn5IkimyZNRXiFDGsMuzIt+lKLI4XDk+LK1fZbm7Ass/87/gk5XU08+XLjRkEmnpa6Qku2m0pqB5i6mJBTYoyNFzCUFhkwBBp0HHFDixnP44BxgLy54PBx67rzlS4vrNjw==;20:3SSYejB5QKFADkt6Cprw8HMf4i1VMZSQ8oFmrvqcmPta+wzpeKxaOY1voob4SwxGLFpZ4C4zNe7EfAjrQM7eyHDel9RVqRalrfVTjakINabOWIAF8jBtWkXOs71ErnbSiJDK/7pLo7qdoAkRaUhAchEjq+MLbYHl530hVQ/wB60= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN3PR03MB1480;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480;BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13024025)(13015025)(13017025)(5005006)(13023025)(8121501046)(10201501046)(3002001);SRVR:BL2PR03MB592;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB592; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;4:QpprGNmIehb8SKJZK9Tt3Sx2EDWb0yUdIhyuGEEO+iJkK1QpyUXanO1COIM9vJKGfOFgXu8yg20jKO4XeklUwIv3ZUxsUIC+uL1nSCqa/MkXQCtFIAwxc+iOkK8Mw6IQOtduhZxw02/01gQo6zJDAf3QZWICh05ATYVBZpR7c9BBleD8Sna1ONd7vh/eJl1PWuiUIeDm85nU1d66hXeRdD9KBzn9PwYieFnmRI8lHU5hR0wfSBaA/NTx8qLL0ip9dFDzYGeahpjU3QWEl5+vQCiFPUVmBoevuG6ta4TWbs9EHByPrCVNKpip/7QUajxf8xHIIrk7VRkJcK7idC+HdrxjLdBBIggB3qZiX1m6mT92emIzm5KbZG8Rl5AHDXCY X-Forefront-PRVS: 08756AC3C8 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(24454002)(377454003)(479174004)(19580395003)(80316001)(19580405001)(5008740100001)(47776003)(43066003)(87976001)(33656002)(122386002)(76176999)(81166005)(42186005)(65806001)(87266999)(54356999)(23746002)(65816999)(586003)(1096002)(6116002)(3846002)(189998001)(2950100001)(5004730100002)(50986999)(77096005)(3450700001)(40100003)(86362001)(50466002)(5001770100001)(83506001)(66066001)(65956001)(2906002)(64126003)(230700001)(4326007)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1480;H:[137.57.160.203];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BN3PR03MB1480;23:5oBLcGekj9V5tKN6XeG6DSyo/cHxuIR9fPwfv?= =?Windows-1252?Q?RJ/afiCdVRuyCEJdb4GyVbECsHJ8UYNQA2y4ul8BPkASY3Vz752v40zL?= =?Windows-1252?Q?QiFGvTm0g27pdXBIC3kGOIiRAF1dHBreyKs1tq/MH4FkcQxCfaiq/wjo?= =?Windows-1252?Q?D8wP9fKjPe9NPokd4bkNP6FNd7rTvTItOcU/N39Ht89IWpL/LTXkEyK9?= =?Windows-1252?Q?b2Ax1Dd8mI4CrfQy+SA7l4sPmsW5pS2NrOa+7tShbUlnSO0aQSkyjiaz?= =?Windows-1252?Q?6D2QM6dNP92BxNd1qiORA+v9CqsVjni7RtVfTrRHgzhfwpgvHmV2VF/L?= =?Windows-1252?Q?XvnirTwLIfV6zMl5bIGShLk9cV7bPFCyXF/ewUC+yfPo9yMCNPFdYuT2?= =?Windows-1252?Q?fXgvFw0mvf83JybFZrWO+lppGf+Aeca2hxynlTQU5HW5Axxe8DiuJfBz?= =?Windows-1252?Q?5gJ/aqUAtP/crWHyE9NYgRrB9KjYq5Is/s6IhK9BGojWHHv3aHOudvmq?= =?Windows-1252?Q?gaktMyyIq9dga9xWTBLqiPDRBd6mBT4jTx3OlwHRincTgskDCSvMoysd?= =?Windows-1252?Q?kvjY4y4GW5n58JTkWVo6aIFJDQ6lU5JF+m9PJlkWN07qimkDujKzBlLg?= =?Windows-1252?Q?7TUol9laQvAVXmmax67I7oTI/csURgTAE4FwHNdg45ANwI4jtgALJ7Ua?= =?Windows-1252?Q?1WWj3kdI/TYbPdDEU39yhL9hWRkKhpXQnMP3GmLGgKOVr24QCCVXUIW4?= =?Windows-1252?Q?Mn+UzqFDrIxB+Kp/RRJ2LyXkP8R+dfWG7YOOOrjSNS/27lIoygUHUalU?= =?Windows-1252?Q?GgJXJhGDBCSBglhZqVzKFJCdkeDT+TIBVb6J/GYFNXgttIXlAGYclwGy?= =?Windows-1252?Q?IW9LhkhYi4M0oWfoAAxIbblp1w6qaI7hf9kWpSMOS5kglqg9bM5ZejG+?= =?Windows-1252?Q?OPIQz0DD34N68zJyNzXzddYbY2ZECV0o1tw/rfc2RHj00yonhOiOyxdD?= =?Windows-1252?Q?5ije5iXU9ncZOtSO0cZi/FLKggsOdwuJWQ8x/9ltP8lfKkQmrJQ/H4du?= =?Windows-1252?Q?/UR1bhj73hzwMQTiumO0lF3NdOmHDJ/5G7OTfXExACBbDo7lqyiPeKkG?= =?Windows-1252?Q?kBL5X6/BHZk/IeCAw0V8rLBmCFsipBsjpckAw1Mw9KxNaAa8mLpmChLn?= =?Windows-1252?Q?7JXBoTfOUM4laYiMg9+xdqmR0O9hOMsZZbv+FEjQD1CW17+0TF0vLUsF?= =?Windows-1252?Q?YATfB/04bB8T0BruWFqtdGNRx2UzpMeeim4BzU=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;5:1oNNL3m//HROwSCbouIC85bCBlAxsVwWiJDlrp8vYbyaELThhuGV/sZ+DcIBGgAkEwb7sPnXB7mMQHE1AkoSrTiHMUUXucq6rhVz636kYZZuauEZ+VaTUnMZQpl2GTygOOYkIsoC3pyWlSotzE5UhQ==;24:+1kAEMYLTCq78BqHjbgOQtBlYAnQoSvfqLoK56nV06o0Vry8z+YQIxjwdhlz5rj6WXAFpolOPlclUCB5v/GrQc/8zHS7h9qGH6qTdu2pRao=;20:bGDdiCIk9PqP2JX/DA2tlq+E4pSFRGpuNesRvtOrecsWcBhYrcA6+3e0ruQbuS3grYfyg2AVh/BHnUdG/lAGEhZUgoqYRsH5omQPfxO0CXjVyAR+Qw0ob53kmRx8oBvEe7EGfsxKc6UkHz2FbbJyQjoemBsRQVGwqW3Ksf7peiM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1480 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD055.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(3190300001)(24454002)(479174004)(377454003)(189002)(199003)(87936001)(19580395003)(19580405001)(80316001)(86362001)(5008740100001)(85426001)(83506001)(16796002)(43066003)(106466001)(105606002)(33656002)(64126003)(50466002)(2950100001)(5004730100002)(5001770100001)(1096002)(1220700001)(6116002)(3846002)(586003)(11100500001)(77096005)(65806001)(66066001)(3720700001)(65956001)(3450700001)(47776003)(956001)(21840400001)(50986999)(76176999)(54356999)(189998001)(2906002)(65816999)(87266999)(4326007)(23746002)(122386002)(230700001)(40100003)(81166005)(6806005)(7099028)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB592;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD055;1:jS1KPrErgc+Ofg3pJtqWFtldrQX4qqoF73hHhWubs79gfSUAGaMU1QZVe4vhBnH4IfnmcA8ool6IutvH0/sJYaB+lfLAfqlIc27mbXUuw1BLly//VLIniMXhOciUMFGebCry+RNSlaIfHol+FX7xW2oD4vMle4+DPXUimH9jsWBUfO5rgGrA52w1V4dKimZQoDzXYblj2EJeMM0I1LrGt/dyRNkU8h173XMXr3tFOgsmKi45FZ2KtWZNt6OTRIZMm0I5bIDSNdQTUNxbe4spzdiNeTOlpazNlnR6AeZrhJDgpVbdpvRPS+Q3OOzVrVQfLSN/Jt07Cd5LWaeP9Ck/3EjjjddrvJPyd1MYx0KzM07E8Tezl+gBYr17f5QXK+GdXjPeddc2+WHfh03I/ESM2Kpaaiw8k1yZrPKpU3x6E5++BQOziN9m/3BbqMSrKgDH3PKfbZC3XBJriXghvJjRolY9nD/XL/MrxXwZCcYZ/xkVZDKvhvhfkn4vU9qv05Br X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB592;2:xcm9q7B9HNmq1DzB2MycU+4KHU2jFoYTJXTW4MQqUNNbhkgDphJzzSwidCkHhAvdI5A5P3OFTTLmKR2p00QBK6zjDKnrprETlOL/kLah1A3zhXPlZTDNDGSELNFzCRgwu/7Mgf9Sce3NfjSW/DVIg9ylzIbPUXxnOKKbz/jIq7Xi+pA8eem4MJ7GDlu6nKiB;3:pZTnzGNEiRlMhIjceuuQ7zj47m812XMBzDV4E/ivtbLKgOX8T5r1uRbc4WaKSZVcy2076iO26wz5+eAe2TcRpWAxkOZLRaPjnIdXJeAmK9A4op2rmj61XryEV7tyccdg6P/LvFZx/LqYLFxCzgti2VxqtiOnaxKije+vz7SuM5gSF7yCEhr0460GCjNKrkdvuFGQYeV2HJQoZx0wlY3MSwG/aQlT+pNum4QafllCizuK5BIS61gjuXBS0NkF7yEg;25:gLWqt5HJXhh/3x7YpFelNOphLkReH0O0ihi8w/exLcTVw2SFzRGWwj8EVOk0N9z6quS1RvKvAODXf0N1v55pk71ZkQa06GeFTWPNBn2cRYAPrgjkWnu5W3W9uMWG3R+NDv4ONkSNX5+jvW9uwRuOysbsEcdLINTEh8hfqJbsltrSgmAmrFXbDgPmWlyeTqgyrhHvs516q29iC1IedGXw0yOtErA0kPjUm0B6T/WRcjMjm+AmijRPfUOeEYpkd4SZn+jmGddZJ1Fhnu9Z8K/v8G2oncobBB/E5vNsXI4DcM3eXyR82jGY0yllVxzlRdR1N6haz1dLqi3TFYm38yOgqg==;20:6CCeZykC8ucv9hsO6LEUeP8fmOW6Xy0ksioCB/SFnJlXn6+CfqKAt8VjQAFrO6O4tSP3lLJ2IpZ1IapZnXWnb+8hVLiYXWK9iFVc7F6cGG7mVrQh8O+YnrZhRs47kRSRrzljxJAZGBFeRe2ifuZ/pc0IIyRo0dyIck3whO0QZO4= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BL2PR03MB592; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB592;4:jHFVo5BdCeBSQ5jcIWUxrYPsPm0QubbjXizllccwRsrJL42Kv3eJwlSzyRnDd+TTQS+S+tBfaQFDblHw8pSsDTsPjuWIE4cyB9eCBggXJcBoDgXZ/Ehwm9vke75KRs2Dmmxpp2lvXQhYwQhtsTzE3UT7bvhZdtcBGEVnrmBemDrRZkqWkDq+ZzXlBmDHBoUd/8aluMnp9VHUTqCq5U8zEL9PKzNL6YSu5jbaPjIYYGq8hVMKE+rYPJMlwuso33nEBPLDUKI/5GOapISHqdk6/GVej6pYwhtMnqW3z+7lEA54mPiUxHef3BmIhJelPVGpBvUDBKh2piRugWLZFWAEh50OA8ZzUrOtwm8ORY+2A0SSXBslFkUUEFL1h6iQIy62OQa3f0Gwxm0jitFy8hdlsbN7T+UOfQ/KehW2J0K5s2lRCzxkrwB0FlYbUcxrBNlbeWXRzOQRU44rLW3hbwqycw== X-Forefront-PRVS: 08756AC3C8 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2PR03MB592;23:eMuCQM7cJXsxLrKuE2ZZC9pq9fnLdJf1jydoBc?= =?Windows-1252?Q?1ic8gt5lUbwZqlXPHqY8XebylRjiw7moPkt0Ubc/5xaHLL+iHUk479Ys?= =?Windows-1252?Q?Zi6EQ/486v8LpwhBksxR1MJ7RSDeFWNeLxe5arIb5miFUwCvQkUVLQ5V?= =?Windows-1252?Q?UDchQHwyW4AoHxo38Fddb3rwzpg5vCma+D098BFlP1+OqKYozSSBqQlO?= =?Windows-1252?Q?I1323XPecPkTII5ZIe7nGlBQemcblGrpK55SSb0nTbQ2cgvUDcS9izD4?= =?Windows-1252?Q?ajlPbml3vb2qCIMsUL5d16tJMjNNiqso8H2WbhByYH8BCNERUppM7d8c?= =?Windows-1252?Q?vCCQkvhtz8GDne86TC+4UxZzytQnv9MSr2r/f7NZRWUCUAI86lKTcxmd?= =?Windows-1252?Q?y37Qjqv635XBE+J30uQ2glZS1AsN0htcMZFfm8TB/N7s0LxA843Iraxt?= =?Windows-1252?Q?+fTTJHzz1R6JSh+bOebsvzlcoXIQvBhXBpX038+/HG9zVPSL0UR7Um9t?= =?Windows-1252?Q?Zw32A3TeNOegPq5OxShyz24SmT+/EhFFZAU3OwI1jjPm/ZL1mqnhEc+2?= =?Windows-1252?Q?3ikT0YMSTs2web8h8gZhGBNilna6fiiUr1Uvo3A4IREJEv9x3bp/T89k?= =?Windows-1252?Q?aKszQ5DSTAx56S1Fsc3B5khvo91y9/cMiJeT/4xqiJLKNgx7XtotCfM5?= =?Windows-1252?Q?GSrYaeV5WYjrGm5yoMgzSHKWl9S8R+3exOvMZHRNupGaj9G9I8l2AqHN?= =?Windows-1252?Q?DV7We9xN8rKEQ5np1nq410jK1Mi+KFqe81tHjK+pKMz2VmEiwDZjD+5h?= =?Windows-1252?Q?oVwHp02FsNosRAeuDd8gYqwBGlezK+glEiN4HkpWdezVgTVgUmMtLVD4?= =?Windows-1252?Q?cvLuu7tkp35Ut6b9p72JuFFjTa8tyx/YTVGUghiuuXLsrFmNwWquhAmG?= =?Windows-1252?Q?tb+7NgWCkictZVI0gL8YIJn524poxDllS/TtM4JfK4wrP4E2Svj628PE?= =?Windows-1252?Q?UBvP8WoA9DN75OdjNVF/OZA18kaKeY9c7fOdfnE8saMx/d5GODS9F+Oz?= =?Windows-1252?Q?oMqaMS9GnKEbnrMvZsyz/JLU07LDsIf6bOGCDA9e0yl6dhLiAmFXLgjJ?= =?Windows-1252?Q?2lkza2Z6DIBlieJeRXJN5Yd3xjfCdr2djSOjqj2reoTIHT3/dMCFJe63?= =?Windows-1252?Q?dscIyfKzXvI+m0d3eXzXuzxrLIk6KN6UMSh582+WyRBOovy8mxXWATG4?= =?Windows-1252?Q?X1sCuu1+e5kGlC/RnpD39atwWJq3uZgHQbsWXwY1FetCVwOb9zHHDp8O?= =?Windows-1252?Q?mUzW+c23WnVWiXOL4obcS5ww91Dj/U047jsPCr3q5sJ+jep2TUk2Lxdu?= =?Windows-1252?Q?kAUJpnp+rIzKgrQVA+1cGOq8KYir77A/xmegUm9HXkw/AIVNezj9NjSt?= =?Windows-1252?Q?lKksu7BM6BNogXzT2Nvqm5yZ1V6JfzckdoYbwq890mPaRJ9PL2q26n9R?= =?Windows-1252?Q?65b+I91XMLM6eJGwfWAh7EHytnoQ2B52VG++ImiV5FyjOxSh7Hb1CHzn?= =?Windows-1252?Q?1lDJ2KZje7Gbm31tf4DpCn/N79I8kdmgSGV5GJdl6meOB1p9t1mtYfc+?= =?Windows-1252?Q?l3Wq07DLq8qG3bEuj4UNw=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB592;5:qsLgS2JQN7TbuaLthX5fjV4YtNp04WJsJnbkV4Rd1Qg9te1sFq2UKZ3c68eQ5T84Z1O0Y/zpXoE9MfsTepb1c+amLEIrIB2cf4Vhd9Z9RvSXf0c4osVVBVb2MnvNWU9Deyp5NX+CEP+xb0Qb3Rdjfg==;24:bbspqnZOv40dLN/r7cRBEtr8ka0hdgz1/l8oUz/+W4Fb6RiWd2UOofcQWMuWUdWFrCCgb4UbK+POMDuaU0ZLR2/3tgcnGuJU58VZxjF8BJw=;20:Jt7xHZ02zS4C3Sy1GmmkWy6ivj3XI2JK0MtHPan61JQ7WiSXTh+YtBbryG9YJ2pOlXCSDvQiO0Drbjztm3pqIWbFQ7y6QxqssND+4Ja9XZKxp8k88Poazav8JBK4Zf4wHHHslM09g+uzkDUaJqwKjVeUvuYbXr1CwLomM/iUUDI= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2016 15:47:39.9465 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB592 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 03/07/2016 01:43 PM, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > In preparation for the Arria10 peripheral ECCs, the IRQ > status needs to be determined because the IRQs are shared. > The IRQ status register is read to determine if the IRQ > was for this ECC peripheral. Cyclone5 and Arria5 have > dedicated IRQs so the confirmation mechanism is not > required and the mask is set to 0. > > Signed-off-by: Thor Thayer > --- > v2: Split large patch into smaller patches. Determine > if IRQ matches this ECC peripheral before handling it. > --- > drivers/edac/altera_edac.c | 41 +++++++++++++++++++++++++++++++---------- > drivers/edac/altera_edac.h | 3 +++ > 2 files changed, 34 insertions(+), 10 deletions(-) > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index fd73a77..11b7291 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -556,19 +556,32 @@ static irqreturn_t altr_edac_device_handler(int irq, void *dev_id) > struct edac_device_ctl_info *dci = dev_id; > struct altr_edac_device_dev *drvdata = dci->pvt_info; > const struct edac_device_prv_data *priv = drvdata->data; > + void __iomem *status_addr = drvdata->status + priv->err_status_ofst; > void __iomem *clear_addr = drvdata->status + priv->clear_err_ofst; > > + /* > + * CycloneV is directly mapped to a specific IRQ. Arria10 > + * shares the IRQ with other ECCs so we must match first. > + */ > if (irq == drvdata->sb_irq) { > - if (priv->ce_clear_mask) > - writel(priv->ce_clear_mask, clear_addr); > - edac_device_handle_ce(dci, 0, 0, drvdata->edac_dev_name); > - ret_value = IRQ_HANDLED; > + if (!priv->ce_status_mask || > + (priv->ce_status_mask & readl(status_addr))) { > + if (priv->ce_clear_mask) > + writel(priv->ce_clear_mask, clear_addr); > + edac_device_handle_ce(dci, 0, 0, > + drvdata->edac_dev_name); > + ret_value = IRQ_HANDLED; > + } > } else if (irq == drvdata->db_irq) { > - if (priv->ue_clear_mask) > - writel(priv->ue_clear_mask, clear_addr); > - edac_device_handle_ue(dci, 0, 0, drvdata->edac_dev_name); > - panic("\nEDAC:ECC_DEVICE[Uncorrectable errors]\n"); > - ret_value = IRQ_HANDLED; > + if (!priv->ue_status_mask || > + (priv->ue_status_mask & readl(status_addr))) { > + if (priv->ue_clear_mask) > + writel(priv->ue_clear_mask, clear_addr); > + edac_device_handle_ue(dci, 0, 0, > + drvdata->edac_dev_name); > + panic("\nEDAC:ECC_DEVICE[Uncorrectable errors]\n"); > + ret_value = IRQ_HANDLED; > + } > } else { > WARN_ON(1); > } While working on subsequent ECC components to upstream, I realized that the above is not an optimal solution for Arria10. The Arria10 is significantly different from the Cyclone5/Arria5 and therefore should be it's own implementation. Please disregard this patch series. I'll redo the series with a different IRQ implementation that is cleaner - it will be closer to the Xgene driver. Sorry for the noise. Thor > @@ -882,6 +895,10 @@ const struct edac_device_prv_data ocramecc_data = { > .ce_clear_mask = (ALTR_OCR_ECC_EN | ALTR_OCR_ECC_SERR), > .ue_clear_mask = (ALTR_OCR_ECC_EN | ALTR_OCR_ECC_DERR), > .clear_err_ofst = ALTR_OCR_ECC_REG_OFFSET, > + /* Cyclone5 & Arria5 have separate IRQs so status = 0 */ > + .ce_status_mask = 0, > + .ue_status_mask = 0, > + .err_status_ofst = 0, > .dbgfs_name = "altr_ocram_trigger", > .alloc_mem = ocram_alloc_mem, > .free_mem = ocram_free_mem, > @@ -957,7 +974,11 @@ const struct edac_device_prv_data l2ecc_data = { > .setup = altr_l2_check_deps, > .ce_clear_mask = 0, > .ue_clear_mask = 0, > - .clear_err_ofst = ALTR_L2_ECC_REG_OFFSET, > + .clear_err_ofst = ALTR_MAN_GRP_L2_ECC_OFFSET, > + /* Cyclone5 & Arria5 have separate IRQs so status = 0 */ > + .ce_status_mask = 0, > + .ue_status_mask = 0, > + .err_status_ofst = 0, > .dbgfs_name = "altr_l2_trigger", > .alloc_mem = l2_alloc_mem, > .free_mem = l2_free_mem, > diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h > index b262f74..43e0dae 100644 > --- a/drivers/edac/altera_edac.h > +++ b/drivers/edac/altera_edac.h > @@ -226,6 +226,9 @@ struct edac_device_prv_data { > int ce_clear_mask; > int ue_clear_mask; > int clear_err_ofst; > + int ce_status_mask; > + int ue_status_mask; > + int err_status_ofst; > char dbgfs_name[20]; > void * (*alloc_mem)(size_t size, void **other); > void (*free_mem)(void *p, size_t size, void *other); >