linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elaine Zhang <zhangqing@rock-chips.com>
To: Caesar Wang <caesar.upstream@gmail.com>, wxt@rock-chips.com
Cc: heiko@sntech.de, khilman@baylibre.com, huangtao@rock-chips.com,
	xxx@rock-chips.com, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org, zyw@rock-chips.com,
	jay.xu@rock-chips.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains
Date: Wed, 09 Mar 2016 16:48:31 +0800	[thread overview]
Message-ID: <56DFE35F.3010400@rock-chips.com> (raw)
In-Reply-To: <56DEB2E1.6060808@gmail.com>



On 03/08/2016 07:09 PM, Caesar Wang wrote:
>
>
> 在 2016年03月03日 16:09, Elaine Zhang 写道:
>> Add binding documentation for the power domains
>> found on Rockchip RK3399 SoCs.
>> RK3399 pd on/off not need to enable clk which in this pd.
>> So remove the clocks in the rk3399 pd example.
>>
>> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
>> ---
>>   .../bindings/soc/rockchip/power_domain.txt         | 37
>> ++++++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>> b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>> index 13dc6a3..98085c8 100644
>> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>> @@ -7,6 +7,7 @@ Required properties for power domain controller:
>>   - compatible: Should be one of the following.
> [....]
>>   Example of the node using power domain:
>> @@ -65,3 +96,9 @@ Example of the node using power domain:
>>                   power-domains = <&power RK3368_PD_GPU_1>;
>>                   /* ... */
>>           };
>> +
>> +    node {
>> +        /* ... */
>> +        power-domains = <&power RK3399_PD_VOPB>;
>> +        /* ... */
>> +    };
>
> Trivial: typo
>                  power: power-controller {
> @@ -92,10 +92,10 @@ Example of the node using power domain:
>          };
>
>          node {
> -                /* ... */
> -                power-domains = <&power RK3368_PD_GPU_1>;
> -                /* ... */
> -        };
> +               /* ... */
> +               power-domains = <&power RK3368_PD_GPU_1>;
> +               /* ... */
> +       };
This is a example.I think there is no problem.

>
>
>
>
>

  reply	other threads:[~2016-03-09  8:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  8:03 [PATCH v5 0/6] rockchip: power-domain: fix pm domain for support RK3399 SoC Elaine Zhang
2016-03-03  8:03 ` [PATCH v5 1/6] rockchip: power-domain: make idle handling optional Elaine Zhang
2016-03-03  8:03 ` [PATCH v5 2/6] power-domain: allow domains only handling idle requests Elaine Zhang
2016-03-03  8:03 ` [PATCH v5 3/6] rockchip: power-domain: add support for sub-power domains Elaine Zhang
2016-03-08 10:41   ` Caesar Wang
2016-03-03  8:03 ` [PATCH v5 4/6] dt/bindings: power: add RK3399 SoCs header for power-domain Elaine Zhang
2016-03-08 10:45   ` Caesar Wang
2016-03-09  8:43     ` Elaine Zhang
2016-03-09  9:55     ` Heiko Stübner
2016-03-09 10:36       ` Caesar Wang
2016-03-09 10:57         ` Heiko Stübner
2016-03-03  8:09 ` [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains Elaine Zhang
2016-03-08 11:09   ` Caesar Wang
2016-03-09  8:48     ` Elaine Zhang [this message]
2016-03-03  8:09 ` [PATCH v5 6/6] rockchip: power-domain: Modify power domain driver for rk3399 Elaine Zhang
2016-03-08 10:59   ` Caesar Wang
     [not found] <[PATCH v5 0_6] rockchip: power-domain: fix pm domain for support RK3399 SoC.eml>
2016-03-03  8:05 ` [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains Elaine Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DFE35F.3010400@rock-chips.com \
    --to=zhangqing@rock-chips.com \
    --cc=caesar.upstream@gmail.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=wxt@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).