From: Ian Abbott <abbotti@mev.co.uk>
To: ravishankarkm <ravishankarkm32@gmail.com>, greg@kroah.com
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Staging: comedi: fix type issue in s626.c
Date: Wed, 9 Mar 2016 10:34:13 +0000 [thread overview]
Message-ID: <56DFFC25.7080306@mev.co.uk> (raw)
In-Reply-To: <1457501390-8844-1-git-send-email-ravishankarkm32@gmail.com>
On 09/03/16 05:29, ravishankarkm wrote:
> This is a patch to the s626.c file that fixes up a type issues
> found by the checkpatch.pl tool.
>
> i.e Prefer kernel type 'u8' over 'uint8_t'
> Prefer kernel type 'u16' over 'uint16_t'
> Prefer kernel type 'u32' over 'uint32_t'
> Prefer kernel type 's16' over 'int16_t'
> Prefer kernel type 's32' over 'int32_t'
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/s626.c | 306 +++++++++++++++++-----------------
> 1 file changed, 153 insertions(+), 153 deletions(-)
Thanks! Just a minor niggle: there are a couple of unconverted
'int16_t' left behind by this patch, but those could be fixed in a
subsequent patch.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-03-09 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 5:29 [PATCH 1/3] Staging: comedi: fix type issue in s626.c ravishankarkm
2016-03-09 5:29 ` [PATCH 2/3] Staging: comedi: fix WARNING " ravishankarkm
2016-03-09 10:34 ` Ian Abbott
2016-03-09 5:29 ` [PATCH 3/3] " ravishankarkm
2016-03-09 10:35 ` Ian Abbott
2016-03-09 10:34 ` Ian Abbott [this message]
2016-03-09 15:33 ` [PATCH 1/3] Staging: comedi: fix type " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DFFC25.7080306@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=greg@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).