From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932689AbcCINgC (ORCPT ); Wed, 9 Mar 2016 08:36:02 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:12418 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbcCINfz (ORCPT ); Wed, 9 Mar 2016 08:35:55 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 09 Mar 2016 05:34:34 -0800 Message-ID: <56E023B2.5020207@nvidia.com> Date: Wed, 9 Mar 2016 18:52:58 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Lee Jones CC: Rhyland Klein , Subject: Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes References: <1455821558-28493-1-git-send-email-rklein@nvidia.com> <20160219085019.GA3410@x1> <56C742C4.4080308@nvidia.com> <56D07ED6.7030607@nvidia.com> <56D43BE1.1080501@nvidia.com> <20160302130828.GB3444@x1> In-Reply-To: <20160302130828.GB3444@x1> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On Wednesday 02 March 2016 06:38 PM, Lee Jones wrote: > On Mon, 29 Feb 2016, Laxman Dewangan wrote: > >> On Friday 26 February 2016 10:05 PM, Rhyland Klein wrote: >>> Did you not see warnings like this when you compiled the kernel? Did you >>> find a different approach than what I proposed above to deal with it? >>> I'd like to get this in soon so that when the max77620 drivers are all >>> in and using it, it should be functional. >>> >> I think the following change also crash in runtime: >> >> /*** >> commit e60a946f05db2cac857025da6ffb72df48d3be54 >> Author: Lee Jones >> >> mfd: ab8500: Provide a small example using new MFD cell MACROs >> >> ***/ >> >> Should we have something MFD_CELL_RES, MFD_CELL_RES_PDATA, >> MFD_CELL_PDATA, for more common user and not to pass the NULL here. > I'll have a re-think about this. Did you get chance to look into this? Probably, I need to send my mfd series once this get fixed before that series applied.