public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] f2fs: clean up opened code with f2fs_update_dentry
@ 2016-03-09 14:07 Chao Yu
  0 siblings, 0 replies; only message in thread
From: Chao Yu @ 2016-03-09 14:07 UTC (permalink / raw)
  To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel

From: Chao Yu <chao@kernel.org>

Just clean up opened code with existing function, no logic change.

Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/dir.c | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index da77e45..e37e0d5 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -347,24 +347,14 @@ int update_dent_inode(struct inode *inode, struct inode *to,
 void do_make_empty_dir(struct inode *inode, struct inode *parent,
 					struct f2fs_dentry_ptr *d)
 {
-	struct f2fs_dir_entry *de;
-
-	de = &d->dentry[0];
-	de->name_len = cpu_to_le16(1);
-	de->hash_code = 0;
-	de->ino = cpu_to_le32(inode->i_ino);
-	memcpy(d->filename[0], ".", 1);
-	set_de_type(de, inode->i_mode);
+	struct qstr dot = QSTR_INIT(".", 1);
+	struct qstr dotdot = QSTR_INIT("..", 2);

-	de = &d->dentry[1];
-	de->hash_code = 0;
-	de->name_len = cpu_to_le16(2);
-	de->ino = cpu_to_le32(parent->i_ino);
-	memcpy(d->filename[1], "..", 2);
-	set_de_type(de, parent->i_mode);
+	/* update dirent of "." */
+	f2fs_update_dentry(inode->i_ino, inode->i_mode, d, &dot, 0, 0);

-	test_and_set_bit_le(0, (void *)d->bitmap);
-	test_and_set_bit_le(1, (void *)d->bitmap);
+	/* update dirent of ".." */
+	f2fs_update_dentry(parent->i_ino, parent->i_mode, d, &dotdot, 0, 1);
 }

 static int make_empty_dir(struct inode *inode,
-- 
2.7.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-09 14:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-09 14:07 [PATCH] f2fs: clean up opened code with f2fs_update_dentry Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox