From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: rpurdie@rpsys.net, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH v2 0/6] leds: Use devm_led_classdev_register
Date: Wed, 09 Mar 2016 16:23:35 +0100 [thread overview]
Message-ID: <56E03FF7.5010604@samsung.com> (raw)
In-Reply-To: <cover.1457449111.git.amitoj1606@gmail.com>
Hi Amitoj,
On 03/09/2016 04:23 AM, Amitoj Kaur Chawla wrote:
> Switch to resource-managed function devm_led_classdev_register instead
> of led_classdev_register and remove unneeded led_classdev_unregister.
>
> The Coccinelle semantic patch used to make this change is as follows:
> //<smpl>
> @platform@
> identifier p, probefn, removefn;
> @@
> struct platform_driver p = {
> .probe = probefn,
> .remove = removefn,
> };
>
> @prb@
> identifier platform.probefn, pdev;
> expression e;
> @@
> probefn(struct platform_device *pdev, ...) {
> ...
> e =
> - led_classdev_register
> + devm_led_classdev_register
> (...);
> ...
> ?- led_classdev_unregister(...);
> ...
> }
> @remove depends on prb@
> identifier platform.removefn;
> @@
> removefn(...) {
> ...
> ?- led_classdev_unregister(...);
> ...
> }
> //</smpl>
>
> Amitoj Kaur Chawla (6):
> leds: 88pm860x: Use devm_led_classdev_register
> leds: lp8788: Use devm_led_classdev_register
> leds: wm831x-status: Use devm_led_classdev_register
> leds: s3c24xx: Use devm_led_classdev_register
> leds: da903x: Use devm_led_classdev_register
> leds: max8997: Use devm_led_classdev_register
>
> Changes in v2:
> -Patches 1-6: Remove unnecessary platform_set_drvdata
> -Patch 4: Remove unnecessary pdev_to_gpio function definition
>
> drivers/leds/leds-88pm860x.c | 12 +-----------
> drivers/leds/leds-da903x.c | 12 +-----------
> drivers/leds/leds-lp8788.c | 14 +-------------
> drivers/leds/leds-max8997.c | 14 +-------------
> drivers/leds/leds-s3c24xx.c | 19 +------------------
> drivers/leds/leds-wm831x-status.c | 13 +------------
> 6 files changed, 6 insertions(+), 78 deletions(-)
>
Thanks for the updated set. All patches have been applied
to the linux-leds.git.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2016-03-09 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 3:23 [PATCH v2 0/6] leds: Use devm_led_classdev_register Amitoj Kaur Chawla
2016-03-09 3:23 ` [PATCH v2 1/6] leds: 88pm860x: " Amitoj Kaur Chawla
2016-03-09 3:23 ` [PATCH v2 2/6] leds: lp8788: " Amitoj Kaur Chawla
2016-03-09 3:23 ` [PATCH v2 3/6] leds: wm831x-status: " Amitoj Kaur Chawla
2016-03-09 3:23 ` [PATCH v2 4/6] leds: s3c24xx: " Amitoj Kaur Chawla
2016-03-09 3:24 ` [PATCH v2 5/6] leds: da903x: " Amitoj Kaur Chawla
2016-03-09 3:24 ` [PATCH v2 6/6] leds: max8997: " Amitoj Kaur Chawla
2016-03-09 15:23 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E03FF7.5010604@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=amitoj1606@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox