From: Helge Deller <deller@gmx.de>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
Ralf Baechle <ralf@linux-mips.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
linux-mips@linux-mips.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PA-RISC: panic immediately when panic_on_oops
Date: Wed, 9 Mar 2016 22:03:36 +0100 [thread overview]
Message-ID: <56E08FA8.8050500@gmx.de> (raw)
In-Reply-To: <1457554123-18491-3-git-send-email-aaro.koskinen@iki.fi>
On 09.03.2016 21:08, Aaro Koskinen wrote:
> PA-RISC wants to sleep 5 seconds before panicking when panic_on_oops
> is set, with no apparent reason.
That's not completely true.
A few years back, when we had lots of crashes, it was very useful to at least
have some time to see the crash before the oops was cleaned from the screen.
Today the parisc port is really stable.
> Remove this feature, since some users
> may want their systems to fail as quickly as possible.
>
> Users who want to delay reboot after panic can use PANIC_TIMEOUT.
That's OK.
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Helge Deller <deller@gmx.de>
> ---
> arch/parisc/kernel/traps.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c
> index 553b098..16e0735 100644
> --- a/arch/parisc/kernel/traps.c
> +++ b/arch/parisc/kernel/traps.c
> @@ -284,11 +284,8 @@ void die_if_kernel(char *str, struct pt_regs *regs, long err)
> if (in_interrupt())
> panic("Fatal exception in interrupt");
>
> - if (panic_on_oops) {
> - printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n");
> - ssleep(5);
> + if (panic_on_oops)
> panic("Fatal exception");
> - }
>
> oops_exit();
> do_exit(SIGSEGV);
>
next prev parent reply other threads:[~2016-03-09 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 20:08 [PATCH 0/2] MIPS/PA-RISC: panic immediately when panic_on_oops Aaro Koskinen
2016-03-09 20:08 ` [PATCH 1/2] MIPS: " Aaro Koskinen
2016-03-09 20:08 ` [PATCH 2/2] PA-RISC: " Aaro Koskinen
2016-03-09 21:03 ` Helge Deller [this message]
2016-03-10 0:09 ` [PATCH 0/2] MIPS/PA-RISC: " Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E08FA8.8050500@gmx.de \
--to=deller@gmx.de \
--cc=aaro.koskinen@iki.fi \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox