From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751454AbcCJNFn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 08:05:43 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:3247 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750773AbcCJNFe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 08:05:34 -0500
Subject: Re: [patch net 2/2] net: hns: fixes a bug of RSS
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, <davem@davemloft.net>
References: <1457576189-22924-1-git-send-email-yankejian@huawei.com>
 <1457576189-22924-3-git-send-email-yankejian@huawei.com>
 <1457598253.1347.52.camel@linux.intel.com>
CC: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>, <liguozhu@huawei.com>,
        <huangdaode@hisilicon.com>, <arnd@arndb.de>, <andrew@lunn.ch>,
        <chenny.xu@huawei.com>, <ivecera@redhat.com>, <lisheng011@huawei.com>,
        <fengguang.wu@intel.com>, <haifeng.wei@huawei.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>
From: "Yankejian (Hackim Yim)" <yankejian@huawei.com>
Message-ID: <56E170B5.90109@huawei.com>
Date: Thu, 10 Mar 2016 21:03:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1457598253.1347.52.camel@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.57.126.191]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020204.56E170C5.029B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 0504d8e6b8deadfcec6d9b613f93ccb5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/3/10 16:24, Andy Shevchenko wrote:
> On Thu, 2016-03-10 at 10:16 +0800, Kejian Yan wrote:
>> If trying to get receive flow hash indirection table by ethtool, it
>> needs
>> to call .get_rxnfc to get ring number first. So this patch implements
>> the
>> .get_rxnfc of ethtool. And the data type of rss_indir_table is u32,
>> it has
>> to be multiply by the width of data type when using memcpy.
> +static int hns_get_rxnfc(struct net_device *netdev,
>> +			 struct ethtool_rxnfc *cmd,
>> +			 u32 *rule_locs)
>> +{
>> +	struct hns_nic_priv *priv = netdev_priv(netdev);
>> +	int ret = 0;
>> +
>> +	switch (cmd->cmd) {
>> +	case ETHTOOL_GRXRINGS:
>> +		cmd->data = priv->ae_handle->q_num;
>> +		break;
>> +	default:
>> +		ret = -EOPNOTSUPP;
>> +		break;
>> +	}
>> +
>> +	return ret;
> Redundant ret variable.
>
> switch (value) {
> case X:
>  break;
> default:
>  return -ERRNO;
> }
>
> return 0;

ok, thanks. i will fix it in next submit.

>> +}