From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753396AbcCJQQo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 11:16:44 -0500
Received: from mail-io0-f174.google.com ([209.85.223.174]:35522 "EHLO
	mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753235AbcCJQQj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 11:16:39 -0500
Subject: Re: [PATCH] tools lib traceevent: Add '~' operation within
 arg_num_eval()
To: Steven Rostedt <rostedt@goodmis.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
References: <1456512767-1164-1-git-send-email-namhyung@kernel.org>
 <1456512767-1164-4-git-send-email-namhyung@kernel.org>
 <20160226214307.GX8720@kernel.org> <20160226214506.GY8720@kernel.org>
 <20160226220819.GZ8720@kernel.org>
 <20160226181328.22f47129@gandalf.local.home> <56D0E3B7.5090202@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <56E19DE9.7020306@gmail.com>
Date: Thu, 10 Mar 2016 09:16:41 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56D0E3B7.5090202@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/26/16 4:45 PM, David Ahern wrote:
> On 2/26/16 4:13 PM, Steven Rostedt wrote:
>> When evaluating values for print flags, if the value included a '~'
>> operator, the parsing would fail. This broke kmalloc's parsing of:
>>
>> __print_flags(REC->gfp_flags, "|", {(unsigned
>> long)((((((( gfp_t)(0x400000u|0x2000000u)) | (( gfp_t)0x40u) |
>> (( gfp_t)0x80u) | (( gfp_t)0x20000u)) | (( gfp_t)0x02u)) |
>> (( gfp_t)0x08u)) | (( gfp_t)0x4000u) | (( gfp_t)0x10000u) |
>> (( gfp_t)0x1000u) | (( gfp_t)0x200u)) & ~(( gfp_t)0x2000000u))
>>                                          ^
>>                                          |
>>                                        here
>>
>> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>> ---
>
> I've been meaning to chase this down for a few weeks. Worked for me.
>
> Tested-by: David Ahern <dsahern@gmail.com>

Arnaldo: have not seen this one hit your tree. Did it fall through the 
cracks?