From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbcCKNDU (ORCPT ); Fri, 11 Mar 2016 08:03:20 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:26460 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbcCKNDK (ORCPT ); Fri, 11 Mar 2016 08:03:10 -0500 X-AuditID: cbfec7f5-f79b16d000005389-0f-56e2c20bff05 Subject: Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint To: Javier Martinez Canillas References: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> <1457122813-12791-3-git-send-email-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Kukjin Kim , Mauro Carvalho Chehab , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org From: Sylwester Nawrocki Message-id: <56E2C206.6020103@samsung.com> Date: Fri, 11 Mar 2016 14:03:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1457122813-12791-3-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xq7rchx6FGXx9x2Lx5u0aJovXLwwt +h+/ZrY42/SG3WLT42usFpd3zWGz6NmwldVixvl9TBarn1U4cHpsWtXJ5rF5Sb3Hlv677B59 W1YxenzeJBfAGsVlk5Kak1mWWqRvl8CV0bNWpmAyZ8Wr3YvZGhg3s3cxcnJICJhIXNqznA3C FpO4cG89kM3FISSwlFGiZ+4CdgjnOaPEn90bgDIcHMICiRLr+iNAGkQETCV+rX3BClHTzCix 4cUjZhCHWWAHk8S61csYQarYBAwleo/2gdm8AloS/as+sYLYLAKqEtN62plAbFGBCInDnV3s EDWCEj8m32MBsTkF3CXeL7jKCrKYWUBP4v5FLZAws4C8xOY1b5knMArMQtIxC6FqFpKqBYzM qxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCAv7rDsalx6wOMQpwMCrx8H649jBMiDWxrLgy 9xCjBAezkgivy4FHYUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgST ZeLglGpgDGuOlH6/4X5X4exj5npz/U0c9S43OM9+xxeZJzRL+0Py0xaT22YR/RrPDu68Kf1h /UV9iYUn9+/etdA4sj9nX3aWbM2H0vNrSy44ex+90blazOTllW1/ZnLFSIl/LrZ4uvKw+XGr SK1rizvWNk5KP7LGwvnD6fYNzcu8nl/YE/bXNtig1br3kxJLcUaioRZzUXEiAL88sMh0AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: > The fimc_md_parse_port_node() function return 0 if an endpoint node is > not found but according to Documentation/devicetree/bindings/graph.txt, > a port must always have at least one enpoint. > > So return an -EINVAL errno code to the caller instead, so it knows that > the port node parse failed due an invalid Device Tree description. I don't think it is forbidden to have a port node in device tree containing no endpoint nodes. Empty port node means only that, for example, a subsystem has a port/bus for connecting external devices but nothing is actually connected to it. In case of Exynos CSIS it might not be so useful to have an empty port node specified in some top level *.dtsi file and only the endpoints specified in a board specific dts file. Nevertheless, I wouldn't be saying in general a port node must always have some endpoint node defined. I could apply this patch as it doesn't do any harm considering existing dts files in the kernel tree (arch/arm/boot/dts/ exynos4412-trats2.dts), but the commit description would need to be changed. -- Thanks, Sylwester