From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932764AbcCKQ2d (ORCPT ); Fri, 11 Mar 2016 11:28:33 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:36389 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932264AbcCKQ23 (ORCPT ); Fri, 11 Mar 2016 11:28:29 -0500 X-AuditID: cbfec7f4-f79026d00000418a-be-56e2f22a28db Subject: Re: [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)" To: Zhaoxiu Zeng References: <1449398669-14507-1-git-send-email-zhaoxiu.zeng@gmail.com> Cc: kyungmin.park@samsung.com, mchehab@osg.samsung.com, kgene@kernel.org, k.kozlowski@samsung.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <56E2F225.3040109@samsung.com> Date: Fri, 11 Mar 2016 17:28:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1449398669-14507-1-git-send-email-zhaoxiu.zeng@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKLMWRmVeSWpSXmKPExsVy+t/xy7panx6FGXxsEbB4/cLQov/xa2aL s01v2C02Pb7GanF51xw2i54NW1ktZpzfx2Sx+lmFxdv5XWwOnB47Z91l99i0qpPNY/OSeo8t /UBe35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZTzZXVywlrPi27dWpgbG2+xdjJwcEgImErf/ nGSFsMUkLtxbz9bFyMUhJLCUUeJ/31kWCOc5o8St1UuYQKqEBZIkNnxeBmaLCGhKzFgyGaxb SMBNYsKaY2BxZoHXjBInF8mB2GwChhK9R/sYQWxeAS2Je4uOg9ksAqoSd5+8B7tCVCBC4nBn FztEjaDEj8n3WEBsTgF3iQlz7gBdxAE0U0/i/kUtiPHyEpvXvGWewCgwC0nHLISqWUiqFjAy r2IUTS1NLihOSs811CtOzC0uzUvXS87P3cQICfwvOxgXH7M6xCjAwajEw/vh2sMwIdbEsuLK 3EOMEhzMSiK8kR8ehQnxpiRWVqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFM lomDU6qBsfkEg82hm+1l+lETbQQPO673CC37HqhS0GkTbLP5aO7x4jfJcoufVx3m25q18X1J WEfCpXeJUmdW/b8tc+PpBK+eieWmpjsjHT/Me2OpU6hTnC5vNMNT8P/rb00nfGOSFxUFMxZq P6iREHux/1u0yfaiXf/0zsnJFnowz5Z9rXlStrqmO/+WEktxRqKhFnNRcSIA2x2xpXgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2015 11:44 AM, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu The patch looks OK, but could you also provide a proper commit message? > Signed-off-by: Zeng Zhaoxiu > --- > drivers/media/platform/exynos4-is/fimc-is-regs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c b/drivers/media/platform/exynos4-is/fimc-is-regs.c > index cfe4406..ec75a24 100644 > --- a/drivers/media/platform/exynos4-is/fimc-is-regs.c > +++ b/drivers/media/platform/exynos4-is/fimc-is-regs.c > @@ -11,6 +11,7 @@ > * published by the Free Software Foundation. > */ > #include > +#include > > #include "fimc-is.h" > #include "fimc-is-command.h" > @@ -107,7 +108,7 @@ int fimc_is_hw_get_params(struct fimc_is *is, unsigned int num_args) > > void fimc_is_hw_set_isp_buf_mask(struct fimc_is *is, unsigned int mask) > { > - if (hweight32(mask) == 1) { > + if (is_power_of_2(mask)) { > dev_err(&is->pdev->dev, "%s(): not enough buffers (mask %#x)\n", > __func__, mask); > return; -- Thanks, Sylwester