From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Ming Lei <tom.leiming@gmail.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
Ming Lin <mlin@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken
Date: Sat, 12 Mar 2016 14:14:35 -0700 [thread overview]
Message-ID: <56E486BB.8030103@kernel.dk> (raw)
In-Reply-To: <CA+55aFyx1+JCs7BuU1TvQ5LzUHaijWV3q-e65g=JCgBkXZFvYA@mail.gmail.com>
On 03/12/2016 12:51 PM, Linus Torvalds wrote:
> On Sat, Mar 12, 2016 at 6:39 AM, Ming Lei <tom.leiming@gmail.com> wrote:
>>
>> I am fine with either way, and I will prepare one patch and let Jens
>> decide.
>
> So guys, this needs to be done *now*.
>
> And Jens - this is the last time I believe you when you say late
> patches are required.
>
> The buggy patch that introduced this problem was part of that very
> late pull request that I already rejected once, and you then claimed
> was absolutely required.
>
> So the dicking around with the block layer stops *now*.
>
> Seriously. I'm pissed off.
Believe me, I'm as impressed as you are...
I've queued it up and will run it through testing and send it off later.
I still think it's better to apply the fix, rather than revert the
original change.
> I don't want to see anything even half-way questionable during the
> whole next release window. Not even during the merge window. You need
> to do some serious quality control, and re-think the whole "large
> changes" model.
The timing was the issue here, and yeah, it didn't work out well this
time at all. It's a momentary lapse, we'll get it sorted for sure.
--
Jens Axboe
prev parent reply other threads:[~2016-03-12 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 7:43 e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Kent Overstreet
2016-03-12 8:04 ` Ming Lin
2016-03-12 8:49 ` Ming Lei
2016-03-12 9:24 ` Kent Overstreet
2016-03-12 10:36 ` Ming Lei
2016-03-12 12:12 ` Kent Overstreet
2016-03-12 13:33 ` Ming Lei
2016-03-12 13:48 ` Kent Overstreet
2016-03-12 14:02 ` Kent Overstreet
2016-03-12 14:25 ` Ming Lei
2016-03-12 14:36 ` Kent Overstreet
2016-03-12 14:39 ` Ming Lei
2016-03-12 19:51 ` Linus Torvalds
2016-03-12 21:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E486BB.8030103@kernel.dk \
--to=axboe@kernel.dk \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlin@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox