From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagig@dev.mellanox.co.il>,
Kent Overstreet <kent.overstreet@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: don't optimize for non-cloned bio in bio_get_last_bvec()
Date: Sat, 12 Mar 2016 21:20:40 -0700 [thread overview]
Message-ID: <56E4EA98.7090304@kernel.dk> (raw)
In-Reply-To: <56E4E575.5020303@kernel.dk>
On 03/12/2016 08:58 PM, Jens Axboe wrote:
> On 03/12/2016 07:56 AM, Ming Lei wrote:
>> For !BIO_CLONED bio, we can use .bi_vcnt safely, but it
>> doesn't mean we can just simply return .bi_io_vec[.bi_vcnt - 1]
>> because the start postion may have been moved in the middle of
>> the bvec, such as splitting in the middle of bvec.
>
> Added and tested.
And Ming, let's not get a repeat of this situation. For critical fixes,
it has to be spot on for post -rc1, especially for code that is
notoriously difficult to get right. Fixes are obviously fine, but it has
to be just enough to fix the regression, no more. This has been too lax,
I expect this to improve.
--
Jens Axboe
prev parent reply other threads:[~2016-03-13 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 14:56 [PATCH] block: don't optimize for non-cloned bio in bio_get_last_bvec() Ming Lei
2016-03-13 3:58 ` Jens Axboe
2016-03-13 4:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E4EA98.7090304@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=sagig@dev.mellanox.co.il \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox