From: "Kim, Milo" <milo.kim@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler
Date: Mon, 14 Mar 2016 08:08:44 +0900 [thread overview]
Message-ID: <56E5F2FC.5070801@ti.com> (raw)
In-Reply-To: <20160311081139.GC31887@mwanda>
On 3/11/2016 5:11 PM, Dan Carpenter wrote:
> Instead to being true/false, the "handled" is true/uninitialized.
> Presumably this doesn't cause that many problems in real life because
> normally we handle the IRQ.
>
> Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Milo Kim <milo.kim@ti.com>
Thanks for catching this!
>
> diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
> index c7a9825..792d51b 100644
> --- a/drivers/mfd/lp8788-irq.c
> +++ b/drivers/mfd/lp8788-irq.c
> @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
> struct lp8788_irq_data *irqd = ptr;
> struct lp8788 *lp = irqd->lp;
> u8 status[NUM_REGS], addr, mask;
> - bool handled;
> + bool handled = false;
> int i;
>
> if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))
>
next prev parent reply other threads:[~2016-03-13 23:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 8:11 [patch] mfd: lp8788-irq: uninitialized variable in irq handler Dan Carpenter
2016-03-13 23:08 ` Kim, Milo [this message]
2016-03-21 11:54 ` Lee Jones
2016-03-21 12:30 ` Dan Carpenter
2016-03-21 18:50 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E5F2FC.5070801@ti.com \
--to=milo.kim@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox