From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933673AbcCNGD0 (ORCPT ); Mon, 14 Mar 2016 02:03:26 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:57073 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933316AbcCNGDY (ORCPT ); Mon, 14 Mar 2016 02:03:24 -0400 X-AuditID: cbfec7f4-f79026d00000418a-0c-56e654278b03 Subject: Re: [PATCH] ARM: dts: Add initial pin configuration for exynos3250-rinato To: Chanwoo Choi , kgene@kernel.org References: <1457917974-314-1-git-send-email-cw00.choi@samsung.com> Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim From: Krzysztof Kozlowski Message-id: <56E65423.1070001@samsung.com> Date: Mon, 14 Mar 2016 15:03:15 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1457917974-314-1-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t/xa7rqIc/CDDbsMbS4/uU5q8X8I+dY LV6/MLToXXCVzaL/8Wtmi02Pr7FaXN41h81ixvl9TA4cHptWdbJ5bF5S79G3ZRWjx+dNcgEs UVw2Kak5mWWpRfp2CVwZl548Zi+4p1hx5/4k1gbGNVJdjBwcEgImEqvOWnYxcgKZYhIX7q1n 62Lk4hASWMooce3uG0YI5ymjxLqdDawgDcICIRJ3lmSBmCICVhIn1qSB9AoJOEvsW7abGaSc WWAto8SvVWsZQRJsAsYSm5cvYQOp5xXQklj1Mw8kzCKgKjH/7lc2EFtUIELicGcXO4jNKyAo 8WPyPRYQm1PARaL7/wawVmYBPYn7F7VAwswC8hKb17xlnsAoMAtJxyyEqllIqhYwMq9iFE0t TS4oTkrPNdQrTswtLs1L10vOz93ECAnsLzsYFx+zOsQowMGoxMP7Y83TMCHWxLLiytxDjBIc zEoivL6Oz8KEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnV wCjYmMd3aoNy2FfJv4tq9m/Y7PTpy4fiRCu15ftOFrQ8nzkpOcnPU0DnT+2tdR3FD3d2cqzS 0tlYULo0hnXHxwSJDNXJK2zOZa6KTUiYab6Vd3NAhbKZ/muN0qVGL/Ryb4We575VlaD987zF CfkO7rhJa+Q36X+/ICYv8+PmksUaGtW3liktKlJiKc5INNRiLipOBACGp9D4aAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 10:12, Chanwoo Choi wrote: > This patch adds initial pin configuration using pinctrl subsystem > to reduce leakage power-consumption of gpio pins in normal state. > All pins included in this patch are NC (not connected) pin. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 38 +++++++++++++++++ > arch/arm/boot/dts/exynos3250-rinato.dts | 70 ++++++++++++++++++++++++++++++- > 2 files changed, 106 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi > index 5ab81c39e2c9..ecf79386e891 100644 > --- a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi > @@ -16,11 +16,49 @@ > #define PIN_PULL_DOWN 1 > #define PIN_PULL_UP 3 > > +#define PIN_DRV_LV1 0 > +#define PIN_DRV_LV2 2 > +#define PIN_DRV_LV3 1 > +#define PIN_DRV_LV4 3 > + > #define PIN_PDN_OUT0 0 > #define PIN_PDN_OUT1 1 > #define PIN_PDN_INPUT 2 > #define PIN_PDN_PREV 3 > > +#define PIN_IN(_pin, _pull, _drv) \ > + _pin { \ > + samsung,pins = #_pin; \ > + samsung,pin-function = <0>; \ > + samsung,pin-pud = ; \ > + samsung,pin-drv = ; \ > + } > + > +#define PIN_OUT(_pin, _drv) \ > + _pin { \ > + samsung,pins = #_pin; \ > + samsung,pin-function = <1>; \ > + samsung,pin-pud = <0>; \ > + samsung,pin-drv = ; \ > + } > + > +#define PIN_OUT_SET(_pin, _val, _drv) \ > + _pin { \ > + samsung,pins = #_pin; \ > + samsung,pin-function = <1>; \ > + samsung,pin-pud = <0>; \ > + samsung,pin-drv = ; \ > + samsung,pin-val = <_val>; \ > + } > + > +#define PIN_CFG(_pin, _sel, _pull, _drv) \ > + _pin { \ > + samsung,pins = #_pin; \ > + samsung,pin-function = <_sel>; \ > + samsung,pin-pud = ; \ > + samsung,pin-drv = ; \ > + } > + > #define PIN_SLP(_pin, _mode, _pull) \ > _pin { \ > samsung,pins = #_pin; \ > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > index 3e64d5dcdd60..1c78a2153776 100644 > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > @@ -681,7 +681,21 @@ > > &pinctrl_0 { > pinctrl-names = "default"; > - pinctrl-0 = <&sleep0>; > + pinctrl-0 = <&initial0 &sleep0>; > + > + initial0: initial-state { > + PIN_IN(gpa1-4, DOWN, LV1); > + PIN_IN(gpa1-5, DOWN, LV1); > + > + PIN_IN(gpc0-0, DOWN, LV1); > + PIN_IN(gpc0-1, DOWN, LV1); > + PIN_IN(gpc0-2, DOWN, LV1); > + PIN_IN(gpc0-3, DOWN, LV1); > + PIN_IN(gpc0-4, DOWN, LV1); > + > + PIN_IN(gpd0-0, DOWN, LV1); > + PIN_IN(gpd0-1, DOWN, LV1); > + }; > > sleep0: sleep-state { > PIN_SLP(gpa0-0, INPUT, DOWN); > @@ -735,7 +749,59 @@ > > &pinctrl_1 { > pinctrl-names = "default"; > - pinctrl-0 = <&sleep1>; > + pinctrl-0 = <&initial1 &sleep1>; > + > + initial1: initial-state { > + PIN_IN(gpe0-6, DOWN, LV1); > + PIN_IN(gpe0-7, DOWN, LV1); > + > + PIN_IN(gpe1-0, DOWN, LV1); > + PIN_IN(gpe1-3, DOWN, LV1); > + PIN_IN(gpe1-4, DOWN, LV1); > + PIN_IN(gpe1-5, DOWN, LV1); > + PIN_IN(gpe1-6, DOWN, LV1); > + > + PIN_IN(gpk2-0, DOWN, LV1); > + PIN_IN(gpk2-1, DOWN, LV1); > + PIN_IN(gpk2-2, DOWN, LV1); > + PIN_IN(gpk2-3, DOWN, LV1); > + PIN_IN(gpk2-4, DOWN, LV1); > + PIN_IN(gpk2-5, DOWN, LV1); > + PIN_IN(gpk2-6, DOWN, LV1); > + > + PIN_IN(gpm0-0, DOWN, LV1); > + PIN_IN(gpm0-1, DOWN, LV1); > + PIN_IN(gpm0-2, DOWN, LV1); > + PIN_IN(gpm0-3, DOWN, LV1); > + PIN_IN(gpm0-4, DOWN, LV1); > + PIN_IN(gpm0-5, DOWN, LV1); > + PIN_IN(gpm0-6, DOWN, LV1); > + PIN_IN(gpm0-7, DOWN, LV1); > + > + PIN_IN(gpm1-0, DOWN, LV1); > + PIN_IN(gpm1-1, DOWN, LV1); > + PIN_IN(gpm1-2, DOWN, LV1); > + PIN_IN(gpm1-3, DOWN, LV1); > + PIN_IN(gpm1-4, DOWN, LV1); > + PIN_IN(gpm1-5, DOWN, LV1); > + PIN_IN(gpm1-6, DOWN, LV1); A blank line here. Beside that: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof