From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343AbcCNGW4 (ORCPT ); Mon, 14 Mar 2016 02:22:56 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:22120 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbcCNGWs (ORCPT ); Mon, 14 Mar 2016 02:22:48 -0400 X-AuditID: cbfec7f4-f79026d00000418a-81-56e658b42a54 Subject: Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56E658AE.5070806@samsung.com> Date: Mon, 14 Mar 2016 15:22:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Zd0tEc/CDFbNEbHYfuQZq8X1L89Z LeYfOcdqMen+BBaLG7/aWC1evzC06H/8mtli0+NrrBaXd81hs5hxfh+TxaKtX9gtDr9pZ7WY Mfklm8WqXX8YHfg8ds66y+6xaVUnm8fmJfUefVtWMXp83iQXwBrFZZOSmpNZllqkb5fAlbHv Tg9TwTWOioPbrrM2MPaydzFycEgImEjsvhDXxcgJZIpJXLi3nq2LkYtDSGApo8SmQ1fYIZyn jBLHtvxkA6kSFvCUmPPlN5gtIpAtMWPJTKiORkaJaUtvs4I4zALNTBJ316xiAqliEzCW2Lx8 CRvEDjmJ3u5JLCA2r4CWxKpvXYwgNouAqsSb9/2sILaoQITE4c4udogaQYkfk++xgJzKKeAm sfa/OIjJLKAncf+iFkgFs4C8xOY1b5knMArOQtIwC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoT c4tL89L1kvNzNzFCoufLDsbFx6wOMQpwMCrx8P5Y8zRMiDWxrLgy9xCjBAezkgivr+OzMCHe lMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFwSjUw+sm6Lb+rdbF+ I/PGCXW5DGk7l56x0crlNp8VfrfMf+c8ts3vD9fPEj5sum/b+zI+QbfbF+X5Op+vvBzgn53o vom5IKXsyOffIi8aTtz36Iy7Yhv7T4tty4PWdTfTk18u33RsdufH2e1JL/68vPNuLhfvCrOp WX+XdP7ySjUXc5dSmnXoq0SZlRJLcUaioRZzUXEiAMc2dgOaAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 11:04, Chanwoo Choi wrote: > This patch adds the MSHC2 (Mobile Storage Host Controller) Device Tree node for > Exynos3250 SoC. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Signed-off-by: Chanwoo Choi > Reviewed-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 35 +++++++++++++++++++++++++++++++ > arch/arm/boot/dts/exynos3250.dtsi | 13 ++++++++++++ > 2 files changed, 48 insertions(+) After looking at your other patch ("ARM: dts: Add initial pin configuration for exynos3250-rinato") I have doubts. The Monk will be affected. Here you are configuring all the gpk2 GPIOS for EMMC2 mode. Then on Rinato you are setting it back to default non-used state. However the Monk board will remain with this new configuration... so you would have to add initial-state also for Monk. But how about doing opposite? Configure here the pins to unused state and enable them only for Artik board? What do you think? Best regards, Krzysztof