From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933577AbcCNGqP (ORCPT ); Mon, 14 Mar 2016 02:46:15 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:22322 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbcCNGqD (ORCPT ); Mon, 14 Mar 2016 02:46:03 -0400 X-AuditID: cbfec7f4-f79026d00000418a-1a-56e65e27561e Subject: Re: [PATCH] kcm: fix variable type To: David Miller References: <1457679075-22094-1-git-send-email-a.hajda@samsung.com> <20160311.114442.1933815095495449507.davem@davemloft.net> Cc: tom@herbertland.com, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Hajda Message-id: <56E65E18.1050907@samsung.com> Date: Mon, 14 Mar 2016 07:45:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160311.114442.1933815095495449507.davem@davemloft.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xy7rqcc/CDBYfl7fYOGM9q8Wc8y0s Fpd3zWGzWHvkLrvFsQViFpcvPWJ2YPPYsvImk0fv3GmsHn1bVjF6fN4kF8ASxWWTkpqTWZZa pG+XwJVxpMWk4Ax7xYzdkQ2MM9i6GDk5JARMJDY8u8kOYYtJXLi3HijOxSEksJRRYsne/ewQ znNGiVunNrJ0MXJwCAtoS5z8wgPSICKgJjHxxARmEFtIoF5iR8sTFhCbWaCZUeLVTiMQm01A U+Lv5ptgy3gFtCRedc5nArFZBFQlln1eC2aLCkRIHO7sYoeoEZT4Mfke2BxOATeJsxf/MIKs ZRbQk7h/UQtivLzE5jVvmScwCsxC0jELoWoWkqoFjMyrGEVTS5MLipPScw31ihNzi0vz0vWS 83M3MULC+MsOxsXHrA4xCnAwKvHw/ljzNEyINbGsuDL3EKMEB7OSCK+v47MwId6UxMqq1KL8 +KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTDW8v6tffmsLv+yQ2B45Pq/ f953/WKYkPfV8FDmXtPqS59PtiaqOrqcqd89x7dbY9qcuZuKs92nznywNH7LC6O+/XYPnnjx VexyNFk8a+akE60qe/bdveklo9Ag9dSK5d5p3RuTHQ4KG3eoajBL2S2OZPdMk6xpuX2hPt/f 4G3nmclHLp4+voJNiaU4I9FQi7moOBEAfqSIYF8CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2016 05:44 PM, David Miller wrote: > From: Andrzej Hajda > Date: Fri, 11 Mar 2016 07:51:15 +0100 > >> Function skb_splice_bits can return negative values, its result should >> be assigned to signed variable to allow correct error checking. >> >> The problem has been detected using patch >> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. >> >> Signed-off-by: Andrzej Hajda > Since skb_splice_bits() returns an 'int', that would be a more appropriate > type to use here. > > Thank you. > > On the other side kcm_splice_read use this local var as return variable, and the return type is ssize_t. Digging deeper it looks like: ssize_t kcm_splice_read(...) returns result of int skb_splice_bits(...) which returns result of ssize_t splice_cb(...) callback. It looks code is somehow inconsistent, but maybe there are other reasons which I am not aware of. Regards Andrzej