From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754807AbcCNG5h (ORCPT ); Mon, 14 Mar 2016 02:57:37 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:58555 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754564AbcCNG5c (ORCPT ); Mon, 14 Mar 2016 02:57:32 -0400 X-AuditID: cbfec7f4-f79026d00000418a-94-56e660d82bb5 Subject: Re: [PATCH 06/10] ARM: dts: Add MSHC0 dt node for eMMC device for exynos3250-artik5 module To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-7-git-send-email-cw00.choi@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56E660D2.9090706@samsung.com> Date: Mon, 14 Mar 2016 15:57:22 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1457921056-21257-7-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xq7o3Ep6FGfxcrWGx/cgzVovrX56z Wsw/co7VYtL9CSwWN361sVq8fmFo0f/4NbPFpsfXWC0u75rDZjHj/D4mi0Vbv7BbHH7Tzmox Y/JLNotVu/4wOvB57Jx1l91j06pONo/NS+o9+rasYvT4vEkugDWKyyYlNSezLLVI3y6BK2Pm ybNMBb18FV0tC9gaGA9xdzFyckgImEgcXHWBHcIWk7hwbz1bFyMXh5DAUkaJA9NXgSWEBJ4y Slx+ngliCwukSnx8dJIZxBYRyJaYsWQmVEMjo8TEy+eZQRxmgWYmibtrVjGBVLEJGEtsXr6E DcTmFdCSeHboENBUDg4WAVWJ7dvlQMKiAhEShzu72CFKBCV+TL7HAmJzCrhJTG0/yQpSziyg J3H/ohZImFlAXmLzmrfMExgFZiHpmIVQNQtJ1QJG5lWMoqmlyQXFSem5hnrFibnFpXnpesn5 uZsYIVHyZQfj4mNWhxgFOBiVeHh/rHkaJsSaWFZcmXuIUYKDWUmE19fxWZgQb0piZVVqUX58 UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YWpBbBZJk4OKUaGIMvzsu3lkjQM7LN4/K+G3bI 99v5V4oWe3VW8krybl+8ozuEZUpy8WPu9bJcUgYrTm31CGyynsZksMeEKcVrbadiGP+0iyXy EnOk2H2TfqzxNz7AyhDDe8jdVOqtgdGe0oLzs/xXvv2jw5ezwlSeJ0SQ+1nv1nZ/mWpe5b/2 fz9xmTXOuHVYiaU4I9FQi7moOBEARldUvI4CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 11:04, Chanwoo Choi wrote: > From: Jaehoon Chung > > This patch adds MSHC (Mobile Storage Host Controller) dt node for Exynos3250 > SoC. MSHC is an interface between the system and the eMMC device. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Andi Shyti > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250-artik5.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi > index 97d0087efb9f..75b291c10cdc 100644 > --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi > +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi > @@ -277,6 +277,25 @@ > }; > }; > > +&mshc_0 { > + num-slots = <1>; > + broken-cd; > + non-removable; Broken or non-removable, not both. > + cap-mmc-highspeed; > + desc-num = <4>; > + card-detect-delay = <200>; > + vmmc-supply = <&ldo11_reg>; Isn't this vqmmc-supply? BTW, both MMC0 regulators (ldo11, ldo12) are marked as always-on. Why they cannot be controlled by XMMC0CDN (just like on Rinato)? What is the benefit of making this patch separate from "Add exynos3250-artik5 dtsi file for ARTIK5 module"? Does the board boot properly without this patch? Best regards, Krzysztof > + clock-frequency = <100000000>; > + clock-freq-min-max = <400000 100000000>; > + samsung,dw-mshc-ciu-div = <1>; > + samsung,dw-mshc-sdr-timing = <0 1>; > + samsung,dw-mshc-ddr-timing = <1 2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>; > + bus-width = <8>; > + status = "okay"; > +}; > + > &xusbxti { > clock-frequency = <24000000>; > }; >