Re: [PATCH 08/10] ARM: dts: Add rtc and adc dt node for exynos3250-artik5 module

Krzysztof Kozlowski
2016-03-14T07:12:50Z

On 14.03.2016 11:04, Chanwoo Choi wrote:
> This patch adds the RTC (Real Time Clock) and ADC (Analog Digital Converter)
> Device Tree node for exynos3250-artik5 module. The RTC is used for wakeup
> source and the ADC is used to read the analog data such as battery temperature.
>
> ADC need to connect the some H/W device such as battery. So, this patch just
> adds the default setting (clock, regulator).
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> arch/arm/boot/dts/exynos3250-artik5.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> index 877e4827df83..673883fda480 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> @@ -48,6 +48,12 @@
> };
> };
>
> +&adc {
> + vdd-supply = <&ldo7_reg>;
> + assigned-clocks = <&cmu CLK_SCLK_TSADC>;
> + assigned-clock-rates = <6000000>;
> +};

No thermistors, status non-okay. What is provided here?

> +
> &cpu0 {
> cpu0-supply = <&buck2_reg>;
> };
> @@ -319,6 +325,12 @@
> status = "okay";
> };
>
> +&rtc {
> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
> + clock-names = "rtc", "rtc_src";
> + status = "okay";
> +};

Same comment as for previous patch - just squash it. Splitting brings no
benefits and makes it more difficult to see bigger picture.

BR,
Krzysztof

> +
> &xusbxti {
> clock-frequency = <24000000>;
> };
>