From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754787AbcCNHGq (ORCPT ); Mon, 14 Mar 2016 03:06:46 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:21388 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbcCNHGl (ORCPT ); Mon, 14 Mar 2016 03:06:41 -0400 X-AuditID: cbfec7f4-f79026d00000418a-b2-56e662fc7ad9 Subject: Re: [PATCH 07/10] ARM: dts: Add thermal zone and cpufreq node for exynos3250-artik5 module To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-9-git-send-email-cw00.choi@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56E662F6.4070200@samsung.com> Date: Mon, 14 Mar 2016 16:06:30 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1457921056-21257-9-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xK7p/kp6FGbT0slhsP/KM1eL6l+es FvOPnGO1mHR/AovFjV9trBavXxha9D9+zWyx6fE1VovLu+awWcw4v4/JYtHWL+wWh9+0s1rM mPySzWLVrj+MDnweO2fdZffYtKqTzWPzknqPvi2rGD0+b5ILYI3isklJzcksSy3St0vgyjj4 oZup4C1Pxc5PE5gaGD9ydjFyckgImEgsPLKGGcIWk7hwbz1bFyMXh5DAUkaJqW/XgiWEBJ4y Stz4FgRiCwukSkz+OocVxBYRyJaYsWQmVEMjo8SVZ+eYQRxmgWYmibtrVjGBVLEJGEtsXr6E DcTmFdCS+PbiNjuIzSKgKvGr/xEjiC0qECFxuLOLHaJGUOLH5HssIDangJvEpeNvgLZxAA3V k7h/UQskzCwgL7F5zVvmCYwCs5B0zEKomoWkagEj8ypG0dTS5ILipPRcQ73ixNzi0rx0veT8 3E2MkDj5soNx8TGrQ4wCHIxKPLw/1jwNE2JNLCuuzD3EKMHBrCTC6+v4LEyINyWxsiq1KD++ qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotgskwcnFINjCsVYy1f777MfGfp9d37uTKn 5s8sem3ygX0rk+jDbCPOk8w/BZ5XRTpK9zOZ3lgqrHvtUe4kzmLrs/F/n+cKntfq9inMUp48 T+SQ8oblh0LcC2tCOUNeflzAlmWYITffjNdobc4+ro/6c+suaH91vaf0O6fK2qWJRfx5bpCa 3Yybm15FGlktUWIpzkg01GIuKk4EAI1qPMWPAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 11:04, Chanwoo Choi wrote: > This patch enables the CPU frequency scaling for exynos3250-artik5 module > and adds the thernal zones with cpu cooling device to prevent the overheat > temperature. > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250-artik5.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) The patch looks good but just squash it with 5/10 unless there is some benefit by splitting the features for many patches. The benefit would be for example submitting the work partially, in steps, following principle release-early-release-often... but this is not the case. You have everything ready and tested. BR, Krzysztof > > diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi > index 75b291c10cdc..877e4827df83 100644 > --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi > +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi > @@ -31,6 +31,25 @@ > compatible = "samsung,secure-firmware"; > reg = <0x0205F000 0x1000>; > }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + cooling-maps { > + map0 { > + /* Corresponds to 500MHz */ > + cooling-device = <&cpu0 5 5>; > + }; > + map1 { > + /* Corresponds to 200MHz */ > + cooling-device = <&cpu0 8 8>; > + }; > + }; > + }; > + }; > +}; > + > +&cpu0 { > + cpu0-supply = <&buck2_reg>; > }; > > &i2c_0 { > @@ -296,6 +315,10 @@ > status = "okay"; > }; > > +&tmu { > + status = "okay"; > +}; > + > &xusbxti { > clock-frequency = <24000000>; > }; >