From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754970AbcCNHVV (ORCPT ); Mon, 14 Mar 2016 03:21:21 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55026 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbcCNHVL (ORCPT ); Mon, 14 Mar 2016 03:21:11 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f793a6d000001364-29-56e66664cda9 Content-transfer-encoding: 8BIT Message-id: <56E66664.3020405@samsung.com> Date: Mon, 14 Mar 2016 16:21:08 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 08/10] ARM: dts: Add rtc and adc dt node for exynos3250-artik5 module References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-10-git-send-email-cw00.choi@samsung.com> <56E66462.9000402@samsung.com> In-reply-to: <56E66462.9000402@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsWyRsSkQDcl7VmYwcKXVhbbjzxjtZh/5Byr xaT7E1gsbvxqY7V4/cLQov/xa2aLTY+vsVpc3jWHzWLG+X1MFou2fmG3OPymndVixuSXbBar dv1hdOD12DnrLrvHplWdbB6bl9R79G1ZxejxeZNcAGsUl01Kak5mWWqRvl0CV8aSP5OZCvr4 K/YsPMHawDiLp4uRk0NCwETi9vWV7BC2mMSFe+vZQGwhgRWMEjuPW8HUXLj5ibmLkQsoPotR 4vzX2SwgCV4BQYkfk+8B2RwczALyEkcuZYOEmQXUJSbNWwRV/4BR4sKf3WwQ9VoS+5c/Zwax WQRUJY48PwcWZwOJv7jBBjJHVCBCovtEJUhYRKBEYu/jKewgc5gFmpkk7q5ZxQSSEBaIlli/ 7hMrxILFjBInJ85iB2nmFNCWWHlDESQuIdDIIfHr7jpWiGUCEt8mHwI7VEJAVmLTAWaIxyQl Dq64wTKBUWwWkndmIbwzC8k7CxiZVzGKphYkFxQnpRcZ6xUn5haX5qXrJefnbmIExurpf8/6 dzDePWB9iFGAg1GJh9fT7lmYEGtiWXFl7iFGU6AjJjJLiSbnAxNCXkm8obGZkYWpiamxkbml mZI470Kpn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGJmPVD2MDL1i+MYoOCyCd5vz3a// d8idfbPvh8gfjkMb90iIW1WtivCbMXH6BtdfK5Im3z5q764RKpURYN/ZuUy9oq6PYZVj6aIG 42XnsyWa9vS3sVhnq694aaAleV3BxqD+ctGl03EJXWsf9K1Z+JW7wvT33KW74xacP+K30ide JHt9l/3EOUosxRmJhlrMRcWJAO502qLQAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xoG5K2rMwg1nvTSy2H3nGajH/yDlW i0n3J7BY3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBZt/cJucfhNO6vFjMkv2SxW 7frD6MDrsXPWXXaPTas62Tw2L6n36NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv 4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAblRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0 Ruj6hgTB9RgZoIGENYwZS/5MZiro46/Ys/AEawPjLJ4uRk4OCQETiQs3PzFD2GISF+6tZ+ti 5OIQEpjFKHH+62wWkASvgKDEj8n3gGwODmYBeYkjl7JBwswC6hKT5i1ihqh/wChx4c9uNoh6 LYn9y5+DDWURUJU48vwcWJwNJP7iBhvIHFGBCInuE5UgYRGBEom9j6ewg8xhFmhmkri7ZhUT SEJYIFpi/bpPrBALFjNKnJw4ix2kmVNAW2LlDcUJjEBXIpw3C+G8WUjOW8DIvIpRIrUguaA4 KT3XMC+1XK84Mbe4NC9dLzk/dxMjOCE8k9rBeHCX+yFGAQ5GJR7eH2uehgmxJpYVV+YeYpTg YFYS4fV1fBYmxJuSWFmVWpQfX1Sak1p8iNEU6L+JzFKiyfnAZJVXEm9obGJmZGlkbmhhZGyu JM77+P+6MCGB9MSS1OzU1ILUIpg+Jg5OqQZGY+2M4hci79mz5DWW8Nz+2Gpf7xP1pKv83zM+ i3qO2rpE2ZysH7Xn1+83bn+Vc3T61PeMF7Kk83ps5jsbVJ94rnGtxPHs76ZI3psvdzczbS9t fZduZSKe3HtKySFspnxr+9TsSb+cnOcFS4eL7Xk96V/UZ5vD15jz1qpzle/20tt1x9etcKYS S3FGoqEWc1FxIgA76sBIHgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 14일 16:12, Krzysztof Kozlowski wrote: > On 14.03.2016 11:04, Chanwoo Choi wrote: >> This patch adds the RTC (Real Time Clock) and ADC (Analog Digital Converter) >> Device Tree node for exynos3250-artik5 module. The RTC is used for wakeup >> source and the ADC is used to read the analog data such as battery temperature. >> >> ADC need to connect the some H/W device such as battery. So, this patch just >> adds the default setting (clock, regulator). >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos3250-artik5.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi >> index 877e4827df83..673883fda480 100644 >> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi >> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi >> @@ -48,6 +48,12 @@ >> }; >> }; >> >> +&adc { >> + vdd-supply = <&ldo7_reg>; >> + assigned-clocks = <&cmu CLK_SCLK_TSADC>; >> + assigned-clock-rates = <6000000>; >> +}; > > No thermistors, status non-okay. What is provided here? The some device are not connected for ADC line on artik5-eval board. This dt node just initialize the basic setting (clock,regulator) ADC of exynos3250 SoC. (I'll change the board name from artik5-devel to artik5-eval on v2 patchset) The vdd-supply for ADC is already fixed on artik5 module. > >> + >> &cpu0 { >> cpu0-supply = <&buck2_reg>; >> }; >> @@ -319,6 +325,12 @@ >> status = "okay"; >> }; >> >> +&rtc { >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>; >> + clock-names = "rtc", "rtc_src"; >> + status = "okay"; >> +}; > > Same comment as for previous patch - just squash it. Splitting brings no > benefits and makes it more difficult to see bigger picture. Okay. I'll merge it with 5/10 patch. Best Regards, Chanwoo Choi