From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933958AbcCNIPq (ORCPT ); Mon, 14 Mar 2016 04:15:46 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53178 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933891AbcCNIPY (ORCPT ); Mon, 14 Mar 2016 04:15:24 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f793c6d00000136c-1d-56e67319fd28 Content-transfer-encoding: 8BIT Message-id: <56E67319.1050502@samsung.com> Date: Mon, 14 Mar 2016 17:15:21 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 06/10] ARM: dts: Add MSHC0 dt node for eMMC device for exynos3250-artik5 module References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-7-git-send-email-cw00.choi@samsung.com> <56E660D2.9090706@samsung.com> In-reply-to: <56E660D2.9090706@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsWyRsSkWFey+FmYwf7b8hbbjzxjtZh/5Byr xaT7E1gsbvxqY7V4/cLQov/xa2aLTY+vsVpc3jWHzWLG+X1MFou2fmG3OPymndVixuSXbBar dv1hdOD12DnrLrvHplWdbB6bl9R79G1ZxejxeZNcAGsUl01Kak5mWWqRvl0CV8bpKdoFW0Qr dq3SbWA8x9fFyMkhIWAi8fLrOxYIW0ziwr31bF2MXBxCAisYJTa2XWeGKfr9ci8zRGIWo8Te WdvYQRK8AoISPybfA+rm4GAWkJc4cikbJMwsoC4xad4iqPoHjBIrbx1jhKjXkvi6pwmsl0VA VWLbg5VsIDYbUHz/ixtsIHNEBSIkuk9UgoRFBEok9j6ewg4yh1mgmUni7ppVTCAJYYFUiY+P TkItWMQoseDyNbAXOAW0JfoedrGCJCQEGjkk3i1+zQyxTUDi2+RDYJdKCMhKbDoA9ZmkxMEV N1gmMIrNQvLPLIR/ZiH5ZwEj8ypG0dSC5ILipPQiI73ixNzi0rx0veT83E2MwFg9/e9Z3w7G mwesDzEKcDAq8fD+WPM0TIg1say4MvcQoynQEROZpUST84EJIa8k3tDYzMjC1MTU2Mjc0kxJ nDdB6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBkbB3ycLC369X6zlb/v8YHVh4jmrhrp/ B+++XNo39ZDorFO9yyaE6sYt8NTi+7lhe5Xx1xlKbKZensbKyy2aRQTvLltRbCJRnzKfZ8om 8UkerYHFRsZ/99662PdhodUEFam2N/dKRNf2VuiwXXgj4njoz6UtbG2zNzNJLHxZuGNf+b2D DlrLfXqUWIozEg21mIuKEwEgyMbh0AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42I5/e+xoK5k8bMwgwOnJSy2H3nGajH/yDlW i0n3J7BY3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBZt/cJucfhNO6vFjMkv2SxW 7frD6MDrsXPWXXaPTas62Tw2L6n36NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv 4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAblRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0 Ruj6hgTB9RgZoIGENYwZp6doF2wRrdi1SreB8RxfFyMnh4SAicTvl3uZIWwxiQv31rN1MXJx CAnMYpTYO2sbO0iCV0BQ4sfkeyxdjBwczALyEkcuZYOEmQXUJSbNW8QMUf+AUWLlrWOMEPVa El/3NIH1sgioSmx7sJINxGYDiu9/cYMNZI6oQIRE94lKkLCIQInE3sdT2EHmMAs0M0ncXbOK CSQhLJAq8fHRSagFixglFly+xgKS4BTQluh72MU6gRHoTIT7ZiHcNwvJfQsYmVcxSqQWJBcU J6XnGuallusVJ+YWl+al6yXn525iBKeDZ1I7GA/ucj/EKMDBqMTD+2PN0zAh1sSy4srcQ4wS HMxKIry+js/ChHhTEiurUovy44tKc1KLDzGaAj04kVlKNDkfmKrySuINjU3MjCyNzA0tjIzN lcR5H/9fFyYkkJ5YkpqdmlqQWgTTx8TBKdXAaHAxyNd2Vj0T6xLL+wKzoo/u3v1ik/lunT8C pdPc7FWVawoYi5kWP46yFi/s751zb8I5k68mEjHfcmfnrunfsUTjFTt3UMuNgsX/O7ftt1/e cfbDx5aIkrKnr0L/eDj7SrkmmJ5Vfzl1z/KzUxaJlRnOlFwvftl0vtIhgahjJo5iVe6+tmWH lViKMxINtZiLihMBCo+OeR0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 14일 15:57, Krzysztof Kozlowski wrote: > On 14.03.2016 11:04, Chanwoo Choi wrote: >> From: Jaehoon Chung >> >> This patch adds MSHC (Mobile Storage Host Controller) dt node for Exynos3250 >> SoC. MSHC is an interface between the system and the eMMC device. >> >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Andi Shyti >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos3250-artik5.dtsi | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi >> index 97d0087efb9f..75b291c10cdc 100644 >> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi >> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi >> @@ -277,6 +277,25 @@ >> }; >> }; >> >> +&mshc_0 { >> + num-slots = <1>; >> + broken-cd; >> + non-removable; > > Broken or non-removable, not both. I'll remove the 'broken-cd' property. > >> + cap-mmc-highspeed; >> + desc-num = <4>; >> + card-detect-delay = <200>; >> + vmmc-supply = <&ldo11_reg>; > > Isn't this vqmmc-supply? I'll fix it as following by using ldo12_reg: vmmc-supply = <&ldo12_reg>; > > BTW, both MMC0 regulators (ldo11, ldo12) are marked as always-on. Why > they cannot be controlled by XMMC0CDN (just like on Rinato)? I'll fix it like rinato board to handle the ldo11/ldo12 as following: gpk0-2 is XMMC0CDN pin. ldo11_reg: LDO11 { - /* VDD_MMC */ + /* VDD74 ~ VDD75 */ regulator-name = "VLDO11_1.8V"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-always-on; + samsung,ext-control-gpios = <&gpk0 2 GPIO_ACTIVE_HIGH>; }; ldo12_reg: LDO12 { @@ -177,7 +178,7 @@ regulator-name = "VLDO12_2.8V"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; - regulator-always-on; + samsung,ext-control-gpios = <&gpk0 2 GPIO_ACTIVE_HIGH>; }; > > What is the benefit of making this patch separate from "Add > exynos3250-artik5 dtsi file for ARTIK5 module"? Does the board boot > properly without this patch? OK. I'll merge it with 5/10 patch. Best Regards, Chanwoo Choi [snip]