From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755155AbcCNI2x (ORCPT ); Mon, 14 Mar 2016 04:28:53 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:50082 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbcCNI2r convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2016 04:28:47 -0400 X-AuditID: cbfee68e-f793c6d00000136c-0f-56e67633bc71 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <56E67632.30602@samsung.com> Date: Mon, 14 Mar 2016 17:28:34 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> <56E658AE.5070806@samsung.com> In-reply-to: <56E658AE.5070806@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsWyRsSkRNe47FmYweJpXBbbjzxjtZh/5Byr xaT7E1gsbvxqY7V4/cLQov/xa2aLTY+vsVpc3jWHzWLG+X1MFou2fmG3OPymndVixuSXbBar dv1hdOD12DnrLrvHplWdbB6bl9R79G1ZxejxeZNcAGsUl01Kak5mWWqRvl0CV8aMDwuYCtp4 K1qmOjYwHufqYuTkkBAwkTi1cSEzhC0mceHeerYuRi4OIYEVjBINr5axwhRNnHAYKrGUUeLQ 31awDl4BQYkfk++xgNjMAuoSk+YtYoawRSQutL5ig7C1JZYtfM0M0fyAUWLn5iuMEM0aEtd3 L2DqYuTgYBFQldj2oA4kzCagJbH/xQ02kLCoQIRE94lKkLCIQInE3sdT2EHGMAs0M0ncXbOK CSQhLOApMefLb7BdQgKLGCWWn44EsTmB9k68dI8JpEFCoJVD4sDUc2CHsggISHybfIgFZIGE gKzEpgNQ30tKHFxxg2UCo/gsJK/NQvLaLCSvzULy2gJGllWMoqkFyQXFSelFRnrFibnFpXnp esn5uZsYgdF9+t+zvh2MNw9YH2IU4GBU4uH9seZpmBBrYllxZe4hRlOgiyYyS4km5wNTSF5J vKGxmZGFqYmpsZG5pZmSOG+C1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYwbm363xu/6 suDFlafnKsMnfLZ3upC5fW9f8zPLJWYrOtcoLHS6oSk53/z8nI15vtql1m6G6fYm7MfbD0jO Xvms78X/xRF8vOvz3ufPF9ba5vRvudYOm/ajy/7fvLhZ8b/2xG0hljErWupnsty6yrCnPHhN XugyGylmvpqWH+GXyl3ijggskP2gxFKckWioxVxUnAgAyDdAW+kCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42I5/e+xgK5x2bMwg5NnGS22H3nGajH/yDlW i0n3J7BY3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBZt/cJucfhNO6vFjMkv2SxW 7frD6MDrsXPWXXaPTas62Tw2L6n36NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv 4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAblRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0 Ruj6hgTB9RgZoIGENYwZd+/3sRe846n4+Gg3UwPjeq4uRk4OCQETiYkTDrNB2GISF+6tB7K5 OIQEljJKHPrbygyS4BUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBdYlJ8xYxQ9Q/YJTYufkKI0S9 hsT13QuYQOpZBFQltj2oAwmzCWhJ7H9xgw0kLCoQIdF9ohIkLCJQIrH38RR2kDHMAs1MEnfX rGICSQgLeErM+fIb7DYhgUWMEstPR4LYnALaEhMv3WOawCgwC8l1sxCum4XkugWMzKsYJVIL kguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgtPBM6kdjAd3uR9iFOBgVOLh/bHmaZgQa2JZcWXu IUYJDmYlEV5fx2dhQrwpiZVVqUX58UWlOanFhxhNgd6byCwlmpwPTFV5JfGGxiZmRpZG5oYW RsbmSuK8j/+vCxMSSE8sSc1OTS1ILYLpY+LglGpg7Mm1WXFUaoJV5rx7ex+zzdz7JF41T/G+ jNoVgbKv9yczT3EPLX8nz2p6ZfHyWLbFn1tX/d15scXPvu2JJFOo056bB+rfrU3JXG6fnKQz /9LzWR1FF97kztw19YPEr9L1Nj3re+8e0dm1SdX9QmRZePD/uSKdXud9me3MLBslJxj+b752 N8FNUomlOCPRUIu5qDgRALETI3odAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 14일 15:22, Krzysztof Kozlowski wrote: > On 14.03.2016 11:04, Chanwoo Choi wrote: >> This patch adds the MSHC2 (Mobile Storage Host Controller) Device Tree node for >> Exynos3250 SoC. >> >> Cc: Kukjin Kim >> Cc: Krzysztof Kozlowski >> Signed-off-by: Chanwoo Choi >> Reviewed-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 35 +++++++++++++++++++++++++++++++ >> arch/arm/boot/dts/exynos3250.dtsi | 13 ++++++++++++ >> 2 files changed, 48 insertions(+) > > > After looking at your other patch ("ARM: dts: Add initial pin > configuration for exynos3250-rinato") I have doubts. The Monk will be > affected. You're right. On monk board, this line may be not stable. > > Here you are configuring all the gpk2 GPIOS for EMMC2 mode. Then on > Rinato you are setting it back to default non-used state. However the > Monk board will remain with this new configuration... so you would have > to add initial-state also for Monk. OK. I'll do it. > > But how about doing opposite? Configure here the pins to unused state > and enable them only for Artik board? > > What do you think? I think that gpk2-[0~6] pins are fixed for MMC2 device. So, it is good to add the pin setting for gpk2-[0~6] to exynos3250-pinctrl.dtsi. If mmc2 device is not used like rinato and monk board, we should add the initial setting as NC (not connected) pin state as other patch (ARM: dts: Add initial pin configuration for exynos3250-rinato). Best Regards, Chanwoo Choi