From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933972AbcCNJod (ORCPT ); Mon, 14 Mar 2016 05:44:33 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32591 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933711AbcCNJoP (ORCPT ); Mon, 14 Mar 2016 05:44:15 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79b16d000005389-e6-56e687eb3f43 Content-transfer-encoding: 8BIT Subject: Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-11-git-send-email-cw00.choi@samsung.com> <56E676EE.8060500@samsung.com> <56E67AE0.9060306@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56E687E6.3070305@samsung.com> Date: Mon, 14 Mar 2016 18:44:06 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-reply-to: <56E67AE0.9060306@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsVy+t/xq7qv25+FGWw7qW6x/cgzVovrX56z Wsw/co7VYtL9CSwWN361sVq8fmFo0f/4NbPFpsfXWC0u75rDZjHj/D4mi0Vbv7BbHH7Tzmox Y/JLNotVu/4wOvB57Jx1l91j06pONo/NS+o9+rasYvT4vEkugDWKyyYlNSezLLVI3y6BK2PX 2QOsBW95K/7+i2xgPM7dxcjJISFgIvF6eg8jhC0mceHeerYuRi4OIYGljBLn+zuYQRK8AoIS PybfY+li5OBgFpCXOHIpG8JUl5gyJRei/CmjxKnLM5hAyoUF0iQWXlnFDmKLCGRLzFgyE2rm IUaJ/ucb2EEcZoFmJom7a1aBdbAJGEtsXr6EDWKZlsSJe51g3SwCqhLTNl5jBbFFBSIkDnd2 gcU5BbQlFi1rZZ3AKDALyX2zEO6bhXDfAkbmVYyiqaXJBcVJ6blGesWJucWleel6yfm5mxgh MfJ1B+PSY1aHGAU4GJV4eH+seRomxJpYVlyZC3QwB7OSCG9H87MwId6UxMqq1KL8+KLSnNTi Q4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBKNTD6t5XwzGmcN9e8pHd30ad0/7CnWcbc 29O+bhbJ/SXPPuWLz+zT5zQcJpxTe3ruT8fB2hcNL5Qi5xSp8FZunrVtb97RvHnXLTl6L3Y0 xe9i+jVt+ue/0nkbpiQ8OKh961tmd5BIGDcvH/eroEnFDeILzefJL5759dfOsMrtnkZ355Z+ tn69uMZeiaU4I9FQi7moOBEAnHYeYY0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 17:48, Chanwoo Choi wrote: > On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote: >> On 14.03.2016 11:04, Chanwoo Choi wrote: >>> From: Jaehoon Chung >>> >>> This patch adds MSHC (Mobile Storage Host Controller) dt node for >>> Exynos3250 SoC. MSHC is an interface between the system and the SD card >>> >>> Signed-off-by: Jaehoon Chung >>> Signed-off-by: Chanwoo Choi >>> --- >>> arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>> index d17c28969118..a371baf8536d 100644 >>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>> @@ -21,6 +21,22 @@ >>> "samsung,exynos3250", "samsung,exynos3"; >>> }; >>> >>> +&mshc_2 { >>> + num-slots = <1>; >>> + cap-sd-highspeed; >>> + disable-wp; >>> + card-detect-delay = <200>; >>> + clock-frequency = <100000000>; >>> + clock-freq-min-max = <400000 100000000>; >>> + samsung,dw-mshc-ciu-div = <1>; >>> + samsung,dw-mshc-sdr-timing = <0 1>; >>> + samsung,dw-mshc-ddr-timing = <1 2>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>; >>> + bus-width = <4>; >>> + status = "okay"; >> >> vqmmc-supply = ldo3? > > ldo3 is always on state because ldo3 is used for various IP in exynos3250. > I think that we had better to remain always on state for ldo3. Yes, I wasn't thinking about toggling ldo3 but about taking the regulator here to model the dependencies between components. Best regards, Krzysztof