From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933711AbcCNJw0 (ORCPT ); Mon, 14 Mar 2016 05:52:26 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:31628 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbcCNJwT (ORCPT ); Mon, 14 Mar 2016 05:52:19 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79b16d000005389-7f-56e689cfd1a3 Content-transfer-encoding: 8BIT Subject: Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> <56E658AE.5070806@samsung.com> <56E67632.30602@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56E689C9.6030405@samsung.com> Date: Mon, 14 Mar 2016 18:52:09 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-reply-to: <56E67632.30602@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xa7rnO5+FGfTdYLXYfuQZq8X1L89Z LeYfOcdqMen+BBaLG7/aWC1evzC06H/8mtli0+NrrBaXd81hs5hxfh+TxaKtX9gtDr9pZ7WY Mfklm8WqXX8YHfg8ds66y+6xaVUnm8fmJfUefVtWMXp83iQXwBrFZZOSmpNZllqkb5fAlbH+ 5RHWgku8FVM+fmFsYPzH1cXIySEhYCJxeOpVVghbTOLCvfVsXYxcHEICSxklDh25wgSS4BUQ lPgx+R5LFyMHB7OAvMSRS9kQprrElCm5EOVPGSW+blnFAlIuLOApMefLbzYQW0QgW2LGkplQ M/czSjQ0T2EBcZgFmpkk7q5ZBbaATcBYYvPyJWwQy7QkVhz7AmazCKhKnJm7mB3EFhWIkDjc 2QVmcwpoSnxdcZxtAqPALCT3zUK4bxbCfQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn525i hETJ1x2MS49ZHWIU4GBU4uH9seZpmBBrYllxZe4hRgkOZiUR3o7mZ2FCvCmJlVWpRfnxRaU5 qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoEk2Xi4JRqYExNnzbdXWz3yn2Kn2fftNKOmJXJ 4pjANzG+fOPSSav3r3oRWTnNtdvFwjy/fr+Qd3mIwVErHQHf099eCIZzbf/MsmuzTHTIYQn5 b8cy509fYJ1w5rDD7QWcn1S1PF60324U913LkbWzbE2J7O3PicE7VictSDoWtfPynDlMYjwn Fm6eJpDwdp8SS3FGoqEWc1FxIgDuVuqajgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 17:28, Chanwoo Choi wrote: > On 2016년 03월 14일 15:22, Krzysztof Kozlowski wrote: >> On 14.03.2016 11:04, Chanwoo Choi wrote: >>> This patch adds the MSHC2 (Mobile Storage Host Controller) Device Tree node for >>> Exynos3250 SoC. >>> >>> Cc: Kukjin Kim >>> Cc: Krzysztof Kozlowski >>> Signed-off-by: Chanwoo Choi >>> Reviewed-by: Krzysztof Kozlowski >>> --- >>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 35 +++++++++++++++++++++++++++++++ >>> arch/arm/boot/dts/exynos3250.dtsi | 13 ++++++++++++ >>> 2 files changed, 48 insertions(+) >> >> >> After looking at your other patch ("ARM: dts: Add initial pin >> configuration for exynos3250-rinato") I have doubts. The Monk will be >> affected. > > You're right. On monk board, this line may be not stable. > >> >> Here you are configuring all the gpk2 GPIOS for EMMC2 mode. Then on >> Rinato you are setting it back to default non-used state. However the >> Monk board will remain with this new configuration... so you would have >> to add initial-state also for Monk. > > OK. I'll do it. > >> >> But how about doing opposite? Configure here the pins to unused state >> and enable them only for Artik board? >> >> What do you think? > > I think that gpk2-[0~6] pins are fixed for MMC2 device. > So, it is good to add the pin setting for gpk2-[0~6] to exynos3250-pinctrl.dtsi. > > If mmc2 device is not used like rinato and monk board, > we should add the initial setting as NC (not connected) pin state > as other patch (ARM: dts: Add initial pin configuration for exynos3250-rinato). Okay, fine to me. BR, Krzysztof