From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964887AbcCNKAL (ORCPT ); Mon, 14 Mar 2016 06:00:11 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:32160 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964805AbcCNJ7x (ORCPT ); Mon, 14 Mar 2016 05:59:53 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79b16d000005389-ca-56e68b964849 Content-transfer-encoding: 8BIT Subject: Re: [PATCH 06/10] ARM: dts: Add MSHC0 dt node for eMMC device for exynos3250-artik5 module To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-7-git-send-email-cw00.choi@samsung.com> <56E660D2.9090706@samsung.com> <56E67319.1050502@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56E68B91.3080906@samsung.com> Date: Mon, 14 Mar 2016 18:59:45 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-reply-to: <56E67319.1050502@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsVy+t/xy7rTup+FGSyepWKx/cgzVovrX56z Wsw/co7VYtL9CSwWN361sVq8fmFo0f/4NbPFpsfXWC0u75rDZjHj/D4mi0Vbv7BbHH7Tzmox Y/JLNotVu/4wOvB57Jx1l91j06pONo/NS+o9+rasYvT4vEkugDWKyyYlNSezLLVI3y6BK6Pv 5CyWgh7eitMTHjI3MD7k6mLk5JAQMJFYtPsyI4QtJnHh3no2EFtIYCmjxLbpkiA2r4CgxI/J 91i6GDk4mAXkJY5cyoYw1SWmTMntYuQCqn7KKHFr6kNmkHJhgVSJj49OgtkiAtkSM5bMhBp5 kFHi+G0WkAZmgWYmibtrVjGBJNgEjCU2L1/CBrFLS+Ll592sIDaLgKrEt6YnYHFRgQiJw51d 7CA2p4C2xJTLn9knMArMQnLeLITzZiGct4CReRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZG SIR83cG49JjVIUYBDkYlHt4fa56GCbEmlhVX5h5ilOBgVhLh7Wh+FibEm5JYWZValB9fVJqT WnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYOTqkGxkkP/R7dqA1b0rr50udyrk2Z5lnV Yv/cZMV+RG21/pJizLr0U9XpKylJaXwSnBKp1y9aXHwmcO5+5MtTT6/IdNdPNzrJ3Z6xK2iV POs3mXeHXKpeTEjfy3EkJffpabtvjLVOvLxHt4hqGqfMd7x1bdeGV5577Lmkfaa4P/81a9rF vr/HTy86dlKJpTgj0VCLuag4EQCRsIHijAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 17:15, Chanwoo Choi wrote: > On 2016년 03월 14일 15:57, Krzysztof Kozlowski wrote: >> On 14.03.2016 11:04, Chanwoo Choi wrote: >>> From: Jaehoon Chung >>> >>> This patch adds MSHC (Mobile Storage Host Controller) dt node for Exynos3250 >>> SoC. MSHC is an interface between the system and the eMMC device. >>> >>> Signed-off-by: Jaehoon Chung >>> Signed-off-by: Andi Shyti >>> Signed-off-by: Chanwoo Choi >>> --- >>> arch/arm/boot/dts/exynos3250-artik5.dtsi | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi >>> index 97d0087efb9f..75b291c10cdc 100644 >>> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi >>> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi >>> @@ -277,6 +277,25 @@ >>> }; >>> }; >>> >>> +&mshc_0 { >>> + num-slots = <1>; >>> + broken-cd; >>> + non-removable; >> >> Broken or non-removable, not both. > > I'll remove the 'broken-cd' property. > >> >>> + cap-mmc-highspeed; >>> + desc-num = <4>; >>> + card-detect-delay = <200>; >>> + vmmc-supply = <&ldo11_reg>; >> >> Isn't this vqmmc-supply? > > I'll fix it as following by using ldo12_reg: > vmmc-supply = <&ldo12_reg>; Sure, looks good. > >> >> BTW, both MMC0 regulators (ldo11, ldo12) are marked as always-on. Why >> they cannot be controlled by XMMC0CDN (just like on Rinato)? > > I'll fix it like rinato board to handle the ldo11/ldo12 as following: > gpk0-2 is XMMC0CDN pin. Great! Thanks, Krzysztof