From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190AbcCNKWq (ORCPT ); Mon, 14 Mar 2016 06:22:46 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:51393 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbcCNKWh convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2016 06:22:37 -0400 X-AuditID: cbfee691-f79766d0000012b6-5b-56e690ea79c6 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <56E690EA.50205@samsung.com> Date: Mon, 14 Mar 2016 19:22:34 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-11-git-send-email-cw00.choi@samsung.com> <56E676EE.8060500@samsung.com> <56E67AE0.9060306@samsung.com> <56E687E6.3070305@samsung.com> In-reply-to: <56E687E6.3070305@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsWyRsSkUPfVhGdhBn/2aFtsP/KM1WL+kXOs FpPuT2CxuPGrjdXi9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWSza+oXd4vCbdlaLGZNfslms 2vWH0YHXY+esu+wem1Z1snlsXlLv0bdlFaPH501yAaxRXDYpqTmZZalF+nYJXBlv17ayFfzh r5j0/xpjA+MG3i5GTg4JAROJrsN3WCFsMYkL99azdTFycQgJrGCU6Nr2ix2m6P6U48wQiaWM Ej+fXQZL8AoISvyYfI+li5GDg1lAXWLKlFyQMLOAiMSfg3+ZIGxtiWULXzOD2EICDxglNt3i h2jVkLh48ywjSCuLgKrEyRshIGE2AS2J/S9usIGERQUiJLpPVIKERQRKJPY+nsIOcgGzQDOT xN01q8DGCwukSSy8sood4rTHjBJvtyxhA0lwAu09O/MdK0hCQqCVQ+LPsTlgX7IICEh8m3wI 7GYJAVmJTQeYIX6UlDi44gbLBEbxWUg+m4Xw2Swkn81C8tkCRpZVjKKpBckFxUnpRaZ6xYm5 xaV56XrJ+bmbGIGxffrfs4k7GO8fsD7EKMDBqMTD+2PN0zAh1sSy4srcQ4ymQAdNZJYSTc4H JpC8knhDYzMjC1MTU2Mjc0szJXFeHemfwUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoY4zX8 jm/nTOabfkcw4b7bmc9vt3Y7WM6zlvfjK13GHfqzS1nka+jxy1Otp2rMl1ytdudMxpVHOzm2 h7RdF33UtDXx6sJjCh8ivT1fsj9mqo+vK14dndoscdxs2dJdJ1SvTuqrevd0TtwN/5UuHutu +S4IezN90c30g/zz7I/HcDt+N3VZe19+ghJLcUaioRZzUXEiANq5liPoAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xgO6rCc/CDB7tUrXYfuQZq8X8I+dY LSbdn8BiceNXG6vF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsli09Qu7xeE37awWMya/ZLNY tesPowOvx85Zd9k9Nq3qZPPYvKTeo2/LKkaPz5vkAlijGhhtMlITU1KLFFLzkvNTMvPSbZW8 g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4BuVFIoS8wpBQoFJBYXK+nbYZoQGuKmawHT GKHrGxIE12NkgAYS1jBmXN4xibFgF3/F3sXnWRsY3/F0MXJySAiYSNyfcpwZwhaTuHBvPVsX IxeHkMBSRomfzy6zgyR4BQQlfky+x9LFyMHBLCAvceRSNoSpLjFlSi5IhZDAA0aJTbf4Iao1 JC7ePMsIUsIioCpx8kYISJhNQEti/4sbbCBhUYEIie4TlSBhEYESib2Pp7CDLGUWaGaSuLtm FRNIQlggTWLhlVXsENc8ZpR4u2UJG0iCU0Bb4uzMd6wTGAVmITluFsJxsxCOW8DIvIpRIrUg uaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOBU8k9rBeHCX+yFGAQ5GJR7eH2uehgmxJpYVV+Ye YpTgYFYS4T3U+yxMiDclsbIqtSg/vqg0J7X4EKMp0HsTmaVEk/OBaSqvJN7Q2MTMyNLI3NDC yNhcSZz38f91YUIC6YklqdmpqQWpRTB9TBycUg2MZavsLR+fn60bPifuzZzZG+UuHPzytPrs BqeVytfc/zUuf7vPJUV/jqst56YEj8e7lhXkFDpuLdk/LfLMxdrb6WsWsU1vWSzUYcsbZt56 /Jfke3OFbRPeTO35Z7Th9jc2+5lXs/IPTTFI0rh9yEhLXVX960S7CediGZZztmnNUuWK2Gad dos9RomlOCPRUIu5qDgRAOdoCVobAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote: > On 14.03.2016 17:48, Chanwoo Choi wrote: >> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote: >>> On 14.03.2016 11:04, Chanwoo Choi wrote: >>>> From: Jaehoon Chung >>>> >>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for >>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card >>>> >>>> Signed-off-by: Jaehoon Chung >>>> Signed-off-by: Chanwoo Choi >>>> --- >>>> arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>> index d17c28969118..a371baf8536d 100644 >>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>> @@ -21,6 +21,22 @@ >>>> "samsung,exynos3250", "samsung,exynos3"; >>>> }; >>>> >>>> +&mshc_2 { >>>> + num-slots = <1>; >>>> + cap-sd-highspeed; >>>> + disable-wp; >>>> + card-detect-delay = <200>; >>>> + clock-frequency = <100000000>; >>>> + clock-freq-min-max = <400000 100000000>; >>>> + samsung,dw-mshc-ciu-div = <1>; >>>> + samsung,dw-mshc-sdr-timing = <0 1>; >>>> + samsung,dw-mshc-ddr-timing = <1 2>; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>; >>>> + bus-width = <4>; >>>> + status = "okay"; >>> >>> vqmmc-supply = ldo3? >> >> ldo3 is always on state because ldo3 is used for various IP in exynos3250. >> I think that we had better to remain always on state for ldo3. > > Yes, I wasn't thinking about toggling ldo3 but about taking the > regulator here to model the dependencies between components. Okay. I'll add it as following: vmmc-supply = <&ldo18_reg>; vqmmc-supply = <&ldo3>; Best Regards, Chanwoo Choi