From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754490AbcCOAZp (ORCPT ); Mon, 14 Mar 2016 20:25:45 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:9168 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003AbcCOAZl (ORCPT ); Mon, 14 Mar 2016 20:25:41 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79b16d000005389-c9-56e756813a91 Content-transfer-encoding: 8BIT Subject: Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-11-git-send-email-cw00.choi@samsung.com> <56E676EE.8060500@samsung.com> <56E67AE0.9060306@samsung.com> <56E687E6.3070305@samsung.com> <56E690EA.50205@samsung.com> Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56E7567B.40301@samsung.com> Date: Tue, 15 Mar 2016 09:25:31 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-reply-to: <56E690EA.50205@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42I5/e/4Fd3GsOdhBtN38FtsP/KM1eL6l+es FvOPnGO1mHR/AovFjV9trBavXxha9D9+zWyx6fE1VovLu+awWcw4v4/JYtHWL+wWh9+0s1rM mPySzWLVrj+MDnweO2fdZffYtKqTzWPzknqPvi2rGD0+b5ILYI3isklJzcksSy3St0vgyvi3 +jdzwWvBipY5J5kbGN/wdTFyckgImEhc6p7IDGGLSVy4t56ti5GLQ0hgKaPE+s3v2UESvAKC Ej8m32PpYuTgYBaQlzhyKRvCVJeYMiUXovwpo8TBphY2kHJhgTSJhVdWgbWKCGRLzFgyEywu JNDAJDHtZjpIA7NAM5PE3TWrmEASbALGEpuXL2GDOEJOord7EtguXgENiefbfEFMFgFViQuv M0EqRAUiJA53doGN5xTQlPjysJ11AqPgLCSHzkI4dBbCoQsYmVcxiqaWJhcUJ6XnGukVJ+YW l+al6yXn525ihMTN1x2MS49ZHWIU4GBU4uGdIfU8TIg1say4MvcQowQHs5II7/EQoBBvSmJl VWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGanphakFsFkmTg4pRoYkwSv3WoNKqv7IDHv wLE7zc5VC0VUu0/q/a3KTSz2/DZr/RcZefPw/uTwcmmDtvk963ruezMfmKH96MPRpN/203Yn XJ1+afbjKXNlUm/evu/S9ktpX2vP1ik7rux2WzhvjvEv722P5f9vWHVu+3bRw+JNbalRU+ds izl9/u0k1iOT1p1PdD8o8E2JpTgj0VCLuag4EQBbzf9mlwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.2016 19:22, Chanwoo Choi wrote: > On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote: >> On 14.03.2016 17:48, Chanwoo Choi wrote: >>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote: >>>> On 14.03.2016 11:04, Chanwoo Choi wrote: >>>>> From: Jaehoon Chung >>>>> >>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for >>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card >>>>> >>>>> Signed-off-by: Jaehoon Chung >>>>> Signed-off-by: Chanwoo Choi >>>>> --- >>>>> arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++ >>>>> 1 file changed, 16 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>> index d17c28969118..a371baf8536d 100644 >>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>> @@ -21,6 +21,22 @@ >>>>> "samsung,exynos3250", "samsung,exynos3"; >>>>> }; >>>>> >>>>> +&mshc_2 { >>>>> + num-slots = <1>; >>>>> + cap-sd-highspeed; >>>>> + disable-wp; >>>>> + card-detect-delay = <200>; >>>>> + clock-frequency = <100000000>; >>>>> + clock-freq-min-max = <400000 100000000>; >>>>> + samsung,dw-mshc-ciu-div = <1>; >>>>> + samsung,dw-mshc-sdr-timing = <0 1>; >>>>> + samsung,dw-mshc-ddr-timing = <1 2>; >>>>> + pinctrl-names = "default"; >>>>> + pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>; >>>>> + bus-width = <4>; >>>>> + status = "okay"; >>>> >>>> vqmmc-supply = ldo3? >>> >>> ldo3 is always on state because ldo3 is used for various IP in exynos3250. >>> I think that we had better to remain always on state for ldo3. >> >> Yes, I wasn't thinking about toggling ldo3 but about taking the >> regulator here to model the dependencies between components. > > Okay. I'll add it as following: > > vmmc-supply = <&ldo18_reg>; > vqmmc-supply = <&ldo3>; ldo18 is not used by mshc2. At least my schematics show that LDO3 goes to DVDD_MMC2 (on different board revision that would be ldo18 instead of ldo3, but not both). The card itself is powered by VDDFLASH_28/MAIN_BAT. BR, Krzysztof