From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754619AbcCOA4j (ORCPT ); Mon, 14 Mar 2016 20:56:39 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:52640 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754328AbcCOA4h (ORCPT ); Mon, 14 Mar 2016 20:56:37 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79646d000001355-42-56e75dc1d885 Content-transfer-encoding: 8BIT Message-id: <56E75DC1.7000807@samsung.com> Date: Tue, 15 Mar 2016 09:56:33 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-11-git-send-email-cw00.choi@samsung.com> <56E676EE.8060500@samsung.com> <56E67AE0.9060306@samsung.com> <56E687E6.3070305@samsung.com> <56E690EA.50205@samsung.com> <56E7567B.40301@samsung.com> In-reply-to: <56E7567B.40301@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsWyRsSkRPdg7PMwg0urdS22H3nGanH9y3NW i/lHzrFaTLo/gcXi9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWSza+oXd4vCbdlaLGZNfslms 2vWH0YHXY+esu+wem1Z1snlsXlLv0bdlFaPH501yAaxRXDYpqTmZZalF+nYJXBm7VhYUXBCu aGtfydbAuFSgi5GTQ0LARGL6rn0sELaYxIV769m6GLk4hARWMEq8XLWTFaao6e1bRojELEaJ p5OOMIIkeAUEJX5MvgfUzcHBLCAvceRSNoSpLjFlSi5E+QNGibcbnzBBlGtJnLnQDtbKIqAq cW3VKjCbTUBHYvu342A1ogJhEg/W7WUFaRYRmMMocejGemYQh1ngNaPE/jVP2UGqhAXSJBZe WcUOsWI+k8SWphawUZwCmhKtF96AtUsI/GWX2Dq1nwVin4DEt8mHwE6VEJCV2HSAGeI1SYmD K26wTGAUm4XkoVkID81CeGgBI/MqRtHUguSC4qT0IkO94sTc4tK8dL3k/NxNjMBoPf3vWe8O xtsHrA8xCnAwKvHwzpB6HibEmlhWXJl7iNEU6IaJzFKiyfnAlJBXEm9obGZkYWpiamxkbmmm JM6rKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVANj3/f1Hh+MzaPrTjdF963KYmyd42qR a8B+1V2qrFHj5wwF0a0TMo+WO7zyak4TPc5/cnLWa85V0yrnceS82f3iy+ndtWc8Drgq3VHI Pmc/ObLsYeib3bn6GW9EDvfoz1ytLzkpNPJx/8uwhRe5rHiduRnmJpx26+U4acEhzprSsnHh IbefqVeUWIozEg21mIuKEwE2NAcZ0QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xoO7B2OdhBiePqFhsP/KM1eL6l+es FvOPnGO1mHR/AovF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsli09Qu7xeE37awWMya/ZLNY tesPowOvx85Zd9k9Nq3qZPPYvKTeo2/LKkaPz5vkAlijGhhtMlITU1KLFFLzkvNTMvPSbZW8 g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4BuVFIoS8wpBQoFJBYXK+nbYZoQGuKmawHT GKHrGxIE12NkgAYS1jBm7FpZUHBBuKKtfSVbA+NSgS5GTg4JAROJprdvGSFsMYkL99azdTFy cQgJzGKUeDrpCFiCV0BQ4sfkeyxdjBwczALyEkcuZUOY6hJTpuRClD9glHi78QkTRLmWxJkL 7WCtLAKqEtdWrQKz2QR0JLZ/Ow5WIyoQJvFg3V5WkGYRgTmMEodurGcGcZgFXjNK7F/zlB2k SlggTWLhlVXsECvmM0lsaWoBG8UpoCnReuEN6wRGoDsRDpyFcOAshAMXMDKvYpRILUguKE5K zzXMSy3XK07MLS7NS9dLzs/dxAhOCM+kdjAe3OV+iFGAg1GJh/eDzPMwIdbEsuLK3EOMEhzM SiK8x0OAQrwpiZVVqUX58UWlOanFhxhNgT6cyCwlmpwPTFZ5JfGGxiZmRpZG5oYWRsbmSuK8 j/+vCxMSSE8sSc1OTS1ILYLpY+LglGpgzN26UvmJok/o58ATrH6b1sbOqN3EZ2t28/CV1dG9 zYGfrh/lmLFBeHOd6WLh/6vOlut2mO0rmhI0ST7ik2qf1U6HF/mP0vc4mD51tV4RYTNfT/rF 2x/cfxi+T/fhuPaQReI06zzXL1XrtzVH+h36a9q6ODkkxHvJMleG4PsJpSXPrP8GrJ/apcRS nJFoqMVcVJwIAG266L0eAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2016 09:25 AM, Krzysztof Kozlowski wrote: > On 14.03.2016 19:22, Chanwoo Choi wrote: >> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote: >>> On 14.03.2016 17:48, Chanwoo Choi wrote: >>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote: >>>>> On 14.03.2016 11:04, Chanwoo Choi wrote: >>>>>> From: Jaehoon Chung >>>>>> >>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for >>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card >>>>>> >>>>>> Signed-off-by: Jaehoon Chung >>>>>> Signed-off-by: Chanwoo Choi >>>>>> --- >>>>>> arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++ >>>>>> 1 file changed, 16 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>> index d17c28969118..a371baf8536d 100644 >>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>> @@ -21,6 +21,22 @@ >>>>>> "samsung,exynos3250", "samsung,exynos3"; >>>>>> }; >>>>>> >>>>>> +&mshc_2 { >>>>>> + num-slots = <1>; >>>>>> + cap-sd-highspeed; >>>>>> + disable-wp; >>>>>> + card-detect-delay = <200>; >>>>>> + clock-frequency = <100000000>; >>>>>> + clock-freq-min-max = <400000 100000000>; >>>>>> + samsung,dw-mshc-ciu-div = <1>; >>>>>> + samsung,dw-mshc-sdr-timing = <0 1>; >>>>>> + samsung,dw-mshc-ddr-timing = <1 2>; >>>>>> + pinctrl-names = "default"; >>>>>> + pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>; >>>>>> + bus-width = <4>; >>>>>> + status = "okay"; >>>>> >>>>> vqmmc-supply = ldo3? >>>> >>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250. >>>> I think that we had better to remain always on state for ldo3. >>> >>> Yes, I wasn't thinking about toggling ldo3 but about taking the >>> regulator here to model the dependencies between components. >> >> Okay. I'll add it as following: >> >> vmmc-supply = <&ldo18_reg>; >> vqmmc-supply = <&ldo3>; > > ldo18 is not used by mshc2. At least my schematics show that LDO3 goes > to DVDD_MMC2 (on different board revision that would be ldo18 instead of > ldo3, but not both). It's confusing..but it seems that Krzysztof's opinion is right. Best Regards, Jaehoon Chung > > The card itself is powered by VDDFLASH_28/MAIN_BAT. > > BR, > Krzysztof > >