From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933317AbcCOBpU (ORCPT ); Mon, 14 Mar 2016 21:45:20 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55295 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbcCOBpS convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2016 21:45:18 -0400 X-AuditID: cbfee690-f79646d000001316-33-56e7692b08bc MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <56E7692A.1020407@samsung.com> Date: Tue, 15 Mar 2016 10:45:14 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jaehoon Chung , Krzysztof Kozlowski , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-11-git-send-email-cw00.choi@samsung.com> <56E676EE.8060500@samsung.com> <56E67AE0.9060306@samsung.com> <56E687E6.3070305@samsung.com> <56E690EA.50205@samsung.com> <56E7567B.40301@samsung.com> <56E75DC1.7000807@samsung.com> In-reply-to: <56E75DC1.7000807@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsWyRsSkSFc783mYwc83IhbbjzxjtZh/5Byr xaT7E1gsbvxqY7V4/cLQov/xa2aLTY+vsVpc3jWHzWLG+X1MFou2fmG3OPymndVixuSXbBar dv1hdOD12DnrLrvHplWdbB6bl9R79G1ZxejxeZNcAGsUl01Kak5mWWqRvl0CV8a/Dd3sBV/F Kk7t2MzYwDhDuIuRk0NCwETiaM8ZVghbTOLCvfVsXYxcHEICKxglvh+YyAxTdK1jIjtEYhaj xNMnn8ESvAKCEj8m32PpYuTgYBZQl5gyJRckzCwgInHgzhsmCFtbYtnC18wQvQ8YJfpeTmGD 6NWSeLh2EpjNIqAqMWXBWxYQmw0ovv/FDTaQmaICERLdJypBekUE5jFK/N9zGGwQs8BrRon9 a56ygzQIC6RJLLyyCuq6fUwS//ZNA7uOE2j1gR93WEESEgKNHBJ/p/xlgVgnIPFt8iGwsyUE ZCU2HYB6U1Li4IobLBMYxWcheW4WwnOzkDw3C8lzCxhZVjGKphYkFxQnpReZ6BUn5haX5qXr JefnbmIERvjpf88m7GC8d8D6EKMAB6MSD+8HmedhQqyJZcWVuYcYTYEOmsgsJZqcD0wjeSXx hsZmRhamJqbGRuaWZkrivK+lfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYMw/Ez+7IcI0 7X0So579bB6ns47X3A9wv5T/O6vuiTO/Q2/ytkUGNTkyxxK8DigvnpPGXKJzXIzl5P3IRREl 4qe4BV3nnWs+mS1d8KQ+NWDV8U0JE26dOqTx6P/E6RW7M/pDruZmmxw5HvFxWvcCv+vRcQzO N2Yf0nyhFPO3/+cxv3kPOu7PeaTEUpyRaKjFXFScCACcTKka6wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xoK525vMwg+dveC22H3nGajH/yDlW i0n3J7BY3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBZt/cJucfhNO6vFjMkv2SxW 7frD6MDrsXPWXXaPTas62Tw2L6n36NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv 4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAblRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0 Ruj6hgTB9RgZoIGENYwZ6/d1MBbMF6v4se4dawPjIaEuRk4OCQETiWsdE9khbDGJC/fWs3Ux cnEICcxilHj65DMzSIJXQFDix+R7LF2MHBzMAvISRy5lQ5jqElOm5EKUP2CU6Hs5hQ2iXEvi 4dpJYDaLgKrElAVvWUBsNqD4/hc32EB6RQUiJLpPVIL0igjMY5T4v+cwM4jDLPCaUWL/mqdg BwkLpEksvLKKHWLDPiaJf/umgR3EKaAtceDHHdYJjEBnItw3C+G+WQj3LWBkXsUokVqQXFCc lJ5rmJdarlecmFtcmpeul5yfu4kRnBCeSe1gPLjL/RCjAAejEg/vB5nnYUKsiWXFlbmHGCU4 mJVEeBMSgEK8KYmVValF+fFFpTmpxYcYTYEenMgsJZqcD0xWeSXxhsYmZkaWRuaGFkbG5kri vI//rwsTEkhPLEnNTk0tSC2C6WPi4JRqYJxyPvX9Tu3Vh+XilVav3BWZnR6mXVintzXvS+ei nAif5CPn/7T8Pitp93mujOmjpQo9jG+17y1rqP7gvNzx95dTyg8D56xXvbBryzf/ICeuG68+ /1Z7k7J7vwv3rFmqb905Hga3v/mkn7GNXa7xmNR+k70V078yeWyOfMKRP+/rs9M1DzSl5B4q sRRnJBpqMRcVJwIA93MsjR4DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 15일 09:56, Jaehoon Chung wrote: > On 03/15/2016 09:25 AM, Krzysztof Kozlowski wrote: >> On 14.03.2016 19:22, Chanwoo Choi wrote: >>> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote: >>>> On 14.03.2016 17:48, Chanwoo Choi wrote: >>>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote: >>>>>> On 14.03.2016 11:04, Chanwoo Choi wrote: >>>>>>> From: Jaehoon Chung >>>>>>> >>>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for >>>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card >>>>>>> >>>>>>> Signed-off-by: Jaehoon Chung >>>>>>> Signed-off-by: Chanwoo Choi >>>>>>> --- >>>>>>> arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++ >>>>>>> 1 file changed, 16 insertions(+) >>>>>>> >>>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>>> index d17c28969118..a371baf8536d 100644 >>>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>>> @@ -21,6 +21,22 @@ >>>>>>> "samsung,exynos3250", "samsung,exynos3"; >>>>>>> }; >>>>>>> >>>>>>> +&mshc_2 { >>>>>>> + num-slots = <1>; >>>>>>> + cap-sd-highspeed; >>>>>>> + disable-wp; >>>>>>> + card-detect-delay = <200>; >>>>>>> + clock-frequency = <100000000>; >>>>>>> + clock-freq-min-max = <400000 100000000>; >>>>>>> + samsung,dw-mshc-ciu-div = <1>; >>>>>>> + samsung,dw-mshc-sdr-timing = <0 1>; >>>>>>> + samsung,dw-mshc-ddr-timing = <1 2>; >>>>>>> + pinctrl-names = "default"; >>>>>>> + pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>; >>>>>>> + bus-width = <4>; >>>>>>> + status = "okay"; >>>>>> >>>>>> vqmmc-supply = ldo3? >>>>> >>>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250. >>>>> I think that we had better to remain always on state for ldo3. >>>> >>>> Yes, I wasn't thinking about toggling ldo3 but about taking the >>>> regulator here to model the dependencies between components. >>> >>> Okay. I'll add it as following: >>> >>> vmmc-supply = <&ldo18_reg>; >>> vqmmc-supply = <&ldo3>; >> >> ldo18 is not used by mshc2. At least my schematics show that LDO3 goes >> to DVDD_MMC2 (on different board revision that would be ldo18 instead of >> ldo3, but not both). ARTIK5 schema document VLDO18 and VLDO3 are connected to DVDD_MMC2_AP. But, I'm not sure what is meaning. So, I'll drop the 'vmmc-supply' > > It's confusing..but it seems that Krzysztof's opinion is right. > > Best Regards, > Jaehoon Chung > >> >> The card itself is powered by VDDFLASH_28/MAIN_BAT. You're right. OK, I'll modify it with only vqmmc-supply = <&ldo3>; Best Regards, Chanwoo Choi