From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933403AbcCOBq5 (ORCPT ); Mon, 14 Mar 2016 21:46:57 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56630 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933209AbcCOBqv (ORCPT ); Mon, 14 Mar 2016 21:46:51 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f793a6d000001364-28-56e76989362e Content-transfer-encoding: 8BIT Message-id: <56E76989.6000008@samsung.com> Date: Tue, 15 Mar 2016 10:46:49 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jaehoon Chung , Krzysztof Kozlowski , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-11-git-send-email-cw00.choi@samsung.com> <56E676EE.8060500@samsung.com> <56E67AE0.9060306@samsung.com> <56E687E6.3070305@samsung.com> <56E690EA.50205@samsung.com> <56E7567B.40301@samsung.com> <56E75DC1.7000807@samsung.com> <56E7692A.1020407@samsung.com> In-reply-to: <56E7692A.1020407@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsWyRsSkULcz83mYwarrxhbbjzxjtZh/5Byr xaT7E1gsbvxqY7V4/cLQov/xa2aLTY+vsVpc3jWHzWLG+X1MFou2fmG3OPymndVixuSXbBar dv1hdOD12DnrLrvHplWdbB6bl9R79G1ZxejxeZNcAGsUl01Kak5mWWqRvl0CV8bSM8cYC76J Vlz/3cfUwLhRqIuRk0NCwETi2d/HjBC2mMSFe+vZuhi5OIQEVjBKfN9+igmm6OGFHnaIxCxG iRk7tzKDJHgFBCV+TL7H0sXIwcEsIC9x5FI2hKkuMWVKLkT5A0aJuxMvQJVrSZz5sBhsGYuA qkTLpJnsIDYbUHz/ixtsIL2iAhES3ScqQXpFBOYxSvzfc5gZxGEWeM0osX/NU7AGYYE0iYVX VkEddJ9Jom/rexaQBKeAtsTcvscsIAkJgb/sEo//XmSHWCcg8W3yIbBLJQRkJTYdYIb4TFLi 4IobLBMYxWYh+WcWwj+zEP5ZwMi8ilE0tSC5oDgpvchYrzgxt7g0L10vOT93EyMwWk//e9a/ g/HuAetDjAIcjEo8vDOknocJsSaWFVfmHmI0BbphIrOUaHI+MCXklcQbGpsZWZiamBobmVua KYnzLpT6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDUwoYWzyM8mWyYezxBd+60qrrOu/ztaRO evt80dNJuoli0sfKo3Iev+RfGegn9rSgJpS1yTUs5/ekl15sl3btVlip2DD1Oau5u/ln09/s N9fMbhRvTZdynikRVF29sU7w4aTvbyczLZ2geLa2P/HhabWzSrvTH/9qMNjzK9RoAV8b48q5 MilupxWUWIozEg21mIuKEwHVC6r50QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xoG5n5vMwg/lHdC22H3nGajH/yDlW i0n3J7BY3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBZt/cJucfhNO6vFjMkv2SxW 7frD6MDrsXPWXXaPTas62Tw2L6n36NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv 4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAblRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0 Ruj6hgTB9RgZoIGENYwZS88cYyz4Jlpx/XcfUwPjRqEuRk4OCQETiYcXetghbDGJC/fWs3Ux cnEICcxilJixcyszSIJXQFDix+R7LF2MHBzMAvISRy5lQ5jqElOm5EKUP2CUuDvxAlS5lsSZ D4sZQWwWAVWJlkkzweazAcX3v7jBBtIrKhAh0X2iEqRXRGAeo8T/PYeZQRxmgdeMEvvXPAVr EBZIk1h4ZRU7xIb7TBJ9W9+zgCQ4BbQl5vY9ZpnACHQmwn2zEO6bhXDfAkbmVYwSqQXJBcVJ 6blGeanlesWJucWleel6yfm5mxjBCeGZ9A7Gw7vcDzEKcDAq8fDOkHoeJsSaWFZcmXuIUYKD WUmENyEBKMSbklhZlVqUH19UmpNafIjRFOjBicxSosn5wGSVVxJvaGxiZmRpZG5oYWRsriTO +/j/ujAhgfTEktTs1NSC1CKYPiYOTqkGxmSmjtpEq1+bTmxO01Dck6E+cQnzolJL5+Cc265N /z8k/ApQuvh+05zHMmvmiqpnGk4W7vzyU+z5j3uNL75vkVqSzsCz7smFFXIrriQ1dxysuefD /Jf3zl2bWW2Lqy/36Bl6sLDJLY6yzF7Foj39UXDvnDhn07dMyw37j7o9PTrZcj3TXI4SMSWW 4oxEQy3mouJEAPp6uoMeAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 15일 10:45, Chanwoo Choi wrote: > On 2016년 03월 15일 09:56, Jaehoon Chung wrote: >> On 03/15/2016 09:25 AM, Krzysztof Kozlowski wrote: >>> On 14.03.2016 19:22, Chanwoo Choi wrote: >>>> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote: >>>>> On 14.03.2016 17:48, Chanwoo Choi wrote: >>>>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote: >>>>>>> On 14.03.2016 11:04, Chanwoo Choi wrote: >>>>>>>> From: Jaehoon Chung >>>>>>>> >>>>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for >>>>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card >>>>>>>> >>>>>>>> Signed-off-by: Jaehoon Chung >>>>>>>> Signed-off-by: Chanwoo Choi >>>>>>>> --- >>>>>>>> arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++ >>>>>>>> 1 file changed, 16 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>>>> index d17c28969118..a371baf8536d 100644 >>>>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts >>>>>>>> @@ -21,6 +21,22 @@ >>>>>>>> "samsung,exynos3250", "samsung,exynos3"; >>>>>>>> }; >>>>>>>> >>>>>>>> +&mshc_2 { >>>>>>>> + num-slots = <1>; >>>>>>>> + cap-sd-highspeed; >>>>>>>> + disable-wp; >>>>>>>> + card-detect-delay = <200>; >>>>>>>> + clock-frequency = <100000000>; >>>>>>>> + clock-freq-min-max = <400000 100000000>; >>>>>>>> + samsung,dw-mshc-ciu-div = <1>; >>>>>>>> + samsung,dw-mshc-sdr-timing = <0 1>; >>>>>>>> + samsung,dw-mshc-ddr-timing = <1 2>; >>>>>>>> + pinctrl-names = "default"; >>>>>>>> + pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>; >>>>>>>> + bus-width = <4>; >>>>>>>> + status = "okay"; >>>>>>> >>>>>>> vqmmc-supply = ldo3? >>>>>> >>>>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250. >>>>>> I think that we had better to remain always on state for ldo3. >>>>> >>>>> Yes, I wasn't thinking about toggling ldo3 but about taking the >>>>> regulator here to model the dependencies between components. >>>> >>>> Okay. I'll add it as following: >>>> >>>> vmmc-supply = <&ldo18_reg>; >>>> vqmmc-supply = <&ldo3>; >>> >>> ldo18 is not used by mshc2. At least my schematics show that LDO3 goes >>> to DVDD_MMC2 (on different board revision that would be ldo18 instead of >>> ldo3, but not both). > > ARTIK5 schema document VLDO18 and VLDO3 are connected to DVDD_MMC2_AP. > But, I'm not sure what is meaning. So, I'll drop the 'vmmc-supply' VLDO18 is not connected to DVDD_MMC2_AP. It is NC state. Sorry for confusion. Best Regards, Chanwoo Choi [snip]