From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933357AbcCOBuZ (ORCPT ); Mon, 14 Mar 2016 21:50:25 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:9858 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932768AbcCOBuX (ORCPT ); Mon, 14 Mar 2016 21:50:23 -0400 X-AuditID: cbfec7f5-f79b16d000005389-15-56e76a5bf6a5 Subject: Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> Cc: Joe Perches , Alexandre Belloni , linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56E76A57.7070104@samsung.com> Date: Tue, 15 Mar 2016 10:50:15 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t/xa7rRWc/DDLp/Mlt0XFvMZPHm7Rom i9n3H7NYvH5haHF51xw2ixnn9zFZ7O/sYHRg93iy6SKjx56JJ9k8tvTfZff4suoas0ffllWM Hp83yQWwRXHZpKTmZJalFunbJXBlTPi8gr1gvVBF4+QJ7A2MR/i6GDk5JARMJNb8nsgOYYtJ XLi3nq2LkYtDSGApo0Tv4i3MEM5TRomru3pZQKqEBTwkds5/yghiiwiESvy7eBvMFhJwldj3 /QZYN7PAPEaJpwdngY1lEzCW2Lx8CRuIzSugJfH2BITNIqAqsX3eE2YQW1QgQuJwZxc7RI2g xI/J98CWcQq4ScybuBGohgNoqJ7E/YtaIGFmAXmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqm liYXFCel5xrpFSfmFpfmpesl5+duYoQE+9cdjEuPWR1iFOBgVOLhnSH1PEyINbGsuDL3EKME B7OSCG9CAlCINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1KzU1MLUotgskwcnFIN jGKapxV3PH7mp38g6se7IuEnhi8KLVPuLru00ki32lv2aW9j58WyCm33b5GCgdnRkWwV/CqH UlderEyZE70peJfD5YuGl1scOzNDJk0+IL+c69XVosT7MWuzitf8uSttIXDoc+EuPjmdzGnT n6mqdu29Xbl6i4rKbBV/6TxWjcpf/2W31KhWKbEUZyQaajEXFScCALkeQ1JyAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.03.2016 10:38, Javier Martinez Canillas wrote: > The clock and source clock looked up by the driver may not be available > just because the clock controller driver was not probed yet so printing > an error in this case is not correct and only adds confusion to users. > > However, knowing that a driver's probe was deferred may be useful so it > can be printed as a debug information. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v3: > - Change debug messages again as suggested by Joe Perches. > > Changes in v2: > - Improve debug messages as suggested by Joe Perches. > > drivers/rtc/rtc-s3c.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index ffb860d18701..d01ad7e8078e 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -501,18 +501,27 @@ static int s3c_rtc_probe(struct platform_device *pdev) > > info->rtc_clk = devm_clk_get(&pdev->dev, "rtc"); > if (IS_ERR(info->rtc_clk)) { > - dev_err(&pdev->dev, "failed to find rtc clock\n"); > - return PTR_ERR(info->rtc_clk); > + ret = PTR_ERR(info->rtc_clk); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to find rtc clock\n"); > + else > + dev_dbg(&pdev->dev, "probe deferred due to missing rtc clk\n"); > + return ret; > } > clk_prepare_enable(info->rtc_clk); > > if (info->data->needs_src_clk) { > info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); > if (IS_ERR(info->rtc_src_clk)) { > - dev_err(&pdev->dev, > - "failed to find rtc source clock\n"); > + ret = PTR_ERR(info->rtc_src_clk); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "failed to find rtc source clock\n"); > + else > + dev_dbg(&pdev->dev, > + "probe deferred due to missing rtc src clk\n"); > clk_disable_unprepare(info->rtc_clk); > - return PTR_ERR(info->rtc_src_clk); > + return ret; > } > clk_prepare_enable(info->rtc_src_clk); > } > The error path starts looking complicated. This has now 4 indentation levels... I agree for removal of error in case of probe deferral because it might be misleading but I don't see much benefit of a debug message. Best regards, Krzysztof