From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934640AbcCOKKr (ORCPT ); Tue, 15 Mar 2016 06:10:47 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:25928 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932247AbcCOKKi (ORCPT ); Tue, 15 Mar 2016 06:10:38 -0400 X-AuditID: cbfec7f4-f79026d00000418a-b8-56e7df945c7d Subject: Re: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions To: Paul Gortmaker References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com> Cc: linux-kernel@vger.kernel.org, Tomasz Figa , Thomas Abraham , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org From: Sylwester Nawrocki Message-id: <56E7DF8C.4030005@samsung.com> Date: Tue, 15 Mar 2016 11:10:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsVy+t/xK7pT7j8PM7hwXN1iyp/lTBabHl9j tdg8/w+jxeVdc9gsZpzfx2Rxbe9xZouOZYwWq3b9YXTg8Ng56y67x51re9g8Ni+p9+jbsorR 4/MmOY/1W7YyBbBFcdmkpOZklqUW6dslcGXs/HWaraCTp2JOzwXWBsYvnF2MnBwSAiYSf35M Y4GwxSQu3FvP1sXIxSEksJRR4v3xbawQznNGiX+T3rKCVAkLJEpsntAH1iEiYCix7M0GqKJ+ Ron5bxawgzjMAi1MEl1bt4B1sAFV9R7tYwSxeQW0JCb1fgfrZhFQlfgx8Tk7iC0qECHxZO5J qBpBiR+T74HVcAr4SlyfdZm5i5EDaKiexP2LWiBhZgF5ic1r3jJPYBSYhaRjFkLVLCRVCxiZ VzGKppYmFxQnpeca6hUn5haX5qXrJefnbmKEhP2XHYyLj1kdYhTgYFTi4Z0h9TxMiDWxrLgy 9xCjBAezkggvJzBqhHhTEiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbL xMEp1cDY37CgUXHz5FaBRbIPW3ic+N8lltZr5RfqBh35bPtT6pxOKfPrZb832xwy2ayyR333 ttO3V2Wcu2QYUHp1U92LhyWvL22af/kb+1F/43mtZqtPBtxN9F+y//VjTrkTjfonavSmlF3n svhd1zhNaRt/oq6Iab7uo7efbr8XCxT40bfW9Orl5c/vK7EUZyQaajEXFScCANanD2p3AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/29/2016 09:48 PM, Paul Gortmaker wrote: > Fixups here tend to be more all over the map vs. some of the other > repeated/systematic ones we've seen elsewhere. > > We remove module.h from code that isn't doing anything modular at > all; if they have __init sections, then replace it with init.h > > A couple drivers have module_exit() code that is essentially orphaned, > and so we remove that. > > There are no module_init replacements, so we have no concerns wrt. > initcall ordering changes as per some of the other cleanups. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Linus Walleij > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 1 - > drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 +++------------ > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 2 +- > drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 2 +- > drivers/pinctrl/samsung/pinctrl-samsung.c | 12 +----------- > 5 files changed, 6 insertions(+), 26 deletions(-) Acked-by: Sylwester Nawrocki -- Thanks, Sylwester