From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934681AbcCOMGo (ORCPT ); Tue, 15 Mar 2016 08:06:44 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:57141 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932378AbcCOMGh (ORCPT ); Tue, 15 Mar 2016 08:06:37 -0400 Subject: Re: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves To: Vineet Gupta , Andreas Ziegler , Bjorn Helgaas References: <1458040615-10697-1-git-send-email-andreas.ziegler@fau.de> CC: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Joao Pinto From: Joao Pinto Message-ID: <56E7FAC7.7030001@synopsys.com> Date: Tue, 15 Mar 2016 12:06:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/15/2016 11:38 AM, Vineet Gupta wrote: > On Tuesday 15 March 2016 04:47 PM, Andreas Ziegler wrote: >> Commit 5f8fc43217a0 ("PCI: Include pci/pcie/Kconfig directly from >> pci/Kconfig") in linux-next changed drivers/pci/Kconfig to include >> drivers/pci/pcie/Kconfig itself, so that architectures do not need >> to source both files themselves. ARC just recently gained PCI support >> through commit 6b3fb77998dd ("ARC: Add PCI support"), but this change >> was based on the old behaviour of the Kconfig files. This makes >> Kconfig now spit out the following warnings: >> >> drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group >> drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group >> drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group >> >> This change updates the Kconfig file for ARC, dropping the now >> unnecessary 'source' statement, which makes the warning disappear. >> >> Signed-off-by: Andreas Ziegler > > Thx for the fix Andreas. > > @Bjorn sorry you might to have to pick this one up as well. > If not, that's fine too - I'll queue it up once ARC PCI hits upstream. > > Thx, > -Vineet > >> --- >> arch/arc/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig >> index 69d05f5..282efec 100644 >> --- a/arch/arc/Kconfig >> +++ b/arch/arc/Kconfig >> @@ -592,7 +592,6 @@ config PCI_SYSCALL >> def_bool PCI >> >> source "drivers/pci/Kconfig" >> -source "drivers/pci/pcie/Kconfig" >> >> endmenu >> > Acked-by: Joao Pinto