public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Eli Cohen <eli@mellanox.com>
Cc: Or Gerlitz <gerlitz.or@gmail.com>, Huy Nguyen <huyn@mellanox.com>,
	Doug Ledford <dledford@redhat.com>,
	Eugenia Emantayev <eugenia@mellanox.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Yishai Hadas <yishaih@mellanox.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Carol L Soto <clsoto@us.ibm.com>,
	Yevgeny Petrilin <yevgenyp@mellanox.com>,
	Brian J King <bjking1@us.ibm.com>
Subject: Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"
Date: Wed, 16 Mar 2016 16:49:00 +1100	[thread overview]
Message-ID: <56E8F3CC.3070203@ozlabs.ru> (raw)
In-Reply-To: <20160316051021.GC66645@x-vnc01.mtx.labs.mlnx>

On 03/16/2016 04:10 PM, Eli Cohen wrote:
> On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote:
>>
>> So with v4.5 as a host, there is no actual distro available today to
>> use as a guest in the next 6 months (or whatever it takes to
>> backport this partucular patch back there).
>>
>> You could have added a module parameter to enforce the old behavoir,
>> at least...
>>
>> And sorry but from the original commit log I could not understand
>> why exactly all existing guests need to be broken. Could you please
>> point me to a piece of documentation describing all this UAR
>> bisuness (what is UAR, why 128 UARs are required and for what, etc).
>> Thanks.
>>
>
> We are going to send a patch that fixes this using a module parameter.
> The patch will be on top of Huy's patch.
>
> Some background to the problem: mlx4 supported devices require 128 UAR

What does UAR stand for?

> pages from PCI memory space defined by BAR2-3. Each UAR page can be
> any power of 2 value from 4K up to 64K. Before Huy's patch the driver
> chose UAR page size to be equal to system page size. Since PowerPC's
> page size is 64K this means minimum requirement of UAR pages is not
> met (default UAR BAR is 8MB and only half of it is really reserved for
> UARs).

And what was the downside? afaict the performance was good...


> More details can be found in the programmer's manual.

Can you please point me to this manual on the website? I tried, honestly, 
could not find it. Thanks.


-- 
Alexey

  reply	other threads:[~2016-03-16  5:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 10:19 [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size" Alexey Kardashevskiy
2016-03-15 10:40 ` Or Gerlitz
2016-03-15 12:18   ` Christoph Hellwig
2016-03-15 14:23     ` Or Gerlitz
2016-03-15 15:29       ` Christoph Hellwig
2016-03-16  1:52         ` Alexey Kardashevskiy
2016-03-16  2:07   ` Alexey Kardashevskiy
2016-03-16  5:10     ` Eli Cohen
2016-03-16  5:49       ` Alexey Kardashevskiy [this message]
2016-03-16  6:09         ` Eli Cohen
2016-03-16  8:34           ` Alexey Kardashevskiy
2016-03-16  9:45             ` Or Gerlitz
2016-03-17  1:40               ` Alexey Kardashevskiy
2016-03-17  5:05                 ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E8F3CC.3070203@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=bjking1@us.ibm.com \
    --cc=clsoto@us.ibm.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=eugenia@mellanox.com \
    --cc=gerlitz.or@gmail.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=huyn@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=sean.hefty@intel.com \
    --cc=yevgenyp@mellanox.com \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox