Re: [GIT PULL] LED subsystem updates for 4.6

Jacek Anaszewski
2016-03-16T07:40:53Z

On 03/16/2016 06:04 AM, Linus Torvalds wrote:
> On Tue, Mar 15, 2016 at 12:51 AM, Jacek Anaszewski
> <j.anaszewski@samsung.com> wrote:
>>
>> I just wanted to make sure that no unexpected problem has occurred
>> after rebasing onto 4.5 release. Is it in some way more advantageous to
>> base a pull request on rc7, than on a final release?
>
> I'd rather see the pull request based on whatever it has been tested
> on, and just keep it that way.
>
> Any rebasing will inevitably mean that you are basically throwing all
> previous testing out the window (or at least make it dubious).
>
> Rebasing also makes it much harder to see the history (for example,
> compare it against previous linux-next trees), so the rule really
> should be that you should never rebase unless you have a major reason
> to do so.
>
> So for example, if you actually find a problem, and you notice that
> that problem comes not from your own changes, but from the base you
> picked - *then* you'd want to rebase to a more stable base. But a
> rebase "just because" is not a good idea.
>
> I'll pull it, since it looks fairly harmless, but basically please
> don't do that again.

Thanks for the explanation. I'll proceed accordingly.

--
Best regards,
Jacek Anaszewski