From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934982AbcCPIXL (ORCPT ); Wed, 16 Mar 2016 04:23:11 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:22230 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934961AbcCPIXH (ORCPT ); Wed, 16 Mar 2016 04:23:07 -0400 Message-ID: <56E917DD.3050901@bfs.de> Date: Wed, 16 Mar 2016 09:22:53 +0100 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Dan Carpenter CC: Jaroslav Kysela , Takashi Iwai , Quentin Lambert , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] ALSA: mixart: silence an uninitialized variable warning References: <20160316074213.GC12860@mwanda> In-Reply-To: <20160316074213.GC12860@mwanda> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.03.2016 08:42, schrieb Dan Carpenter: > We could print the uninitialized value of "stat" in the error message. > > Signed-off-by: Dan Carpenter > > diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c > index bc81b9f..25c0ddd 100644 > --- a/sound/pci/mixart/mixart.c > +++ b/sound/pci/mixart/mixart.c > @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr, > } > > if(start) { > - u32 stat; > + u32 stat = 0; > > group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */ > @maintainer: can someone please fix/remove the comment here ? it read like if (pipe_count==0) pipe_count = 0. just my 2 cents, re, wh > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >