From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935135AbcCPPJE (ORCPT ); Wed, 16 Mar 2016 11:09:04 -0400 Received: from mout01.posteo.de ([185.67.36.65]:35071 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932331AbcCPPJC (ORCPT ); Wed, 16 Mar 2016 11:09:02 -0400 Subject: Re: [PATCH] mmc: card: don't use PF_MEMALLOC To: Jens Axboe , ulf.hansson@linaro.org, chuanxiao.dong@intel.com, fabf@skynet.be References: <1458128635-3539-1-git-send-email-martink@posteo.de> <56E9707D.5070004@fb.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Martin Kepplinger X-Enigmail-Draft-Status: N1110 Message-ID: <56E976A9.40906@posteo.de> Date: Wed, 16 Mar 2016 16:07:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E9707D.5070004@fb.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2016-03-16 um 15:41 schrieb Jens Axboe: > On 03/16/2016 04:43 AM, Martin Kepplinger wrote: >> PF_MEMALLOC is assigned to processes by mm. If drivers prevent memory >> reclaim and mm is not in control, strange hang-up or OOM Killer >> invocation >> could happen. >> >> Signed-off-by: Martin Kepplinger >> --- >> I use MMC cards with this change perfectly fine. As I understand it, >> even *if* PF_MEMALLOC has a real reason to be here, I think it should >> be very well documented. > > Did you try swap on mmcblk? > No I haven't even thought about that :) If you know it can be necessary in that case, it's obviously fine. A comment would still be good though.