From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965892AbcCPVuV (ORCPT ); Wed, 16 Mar 2016 17:50:21 -0400 Received: from mail-bn1on0096.outbound.protection.outlook.com ([157.56.110.96]:11200 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750953AbcCPVuN (ORCPT ); Wed, 16 Mar 2016 17:50:13 -0400 X-Greylist: delayed 5644 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Mar 2016 17:50:13 EDT Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O45EYS-07-G9N-02 X-M-MSG: Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver To: Hans de Goede , Tejun Heo References: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> <20160125204300.GM3628@mtj.duckdns.org> <56A73E39.70109@redhat.com> CC: , , , From: Brijesh Singh Message-ID: <56E9BE45.8030101@amd.com> Date: Wed, 16 Mar 2016 15:12:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56A73E39.70109@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(189002)(377424004)(199003)(377454003)(24454002)(83506001)(5004730100002)(64126003)(189998001)(230700001)(36756003)(47776003)(101416001)(106466001)(105586002)(19580395003)(80316001)(19580405001)(92566002)(50466002)(5008740100001)(2950100001)(76176999)(586003)(50986999)(65816999)(87266999)(1220700001)(54356999)(5001770100001)(4326007)(23746002)(3846002)(33656002)(6116002)(1096002)(87936001)(77096005)(2906002)(4001350100001)(11100500001)(86362001)(81166005);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0854;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: c0d38374-fed4-4b0e-0133-08d34dd7ce09 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;2:H8eTdL7uUWXY2aA3xYRS/muQUkIw8JK297YJVRNcud/GvklRf4Fqv5xDwT2pXr5G5ExEE0GT9EpMYAzL3Yix1D+RoCQrjsrD9GYQJX1PcbL2qmziLk0eO2vNcnB62WdyuGlN/rJ2CuXXIzT/6PYNffTShxG1iVU9HUIR0Cj5ztTSC5i1uhWKr2H0YBCL/Ipu;3:e9zuoywBt5M3QsZNzYAp+AflwsKoZxaHCeoKRfvqVsIzVM0IRMacKe2dbDUm4W0fOXXW1UVtuxbH2W1b7Jr2G30ZvC3SXRDGGOO5zx0ucYUmz326VWtB3gZ26vmiEwSHhL8khKHX/aLI9/OVeoezhVAagDmnkY58wme2MhWIq5X8XPIec+hlp5N9ZeIBXaZc912Od39WNOvHB9WZO7RwInJZC7lVlPYOyHRleodQp78=;25:rNna0WX/UzIhgxcYurGL1jiBlDZiVLl27ZP3jX7n3RmIuzbuaE0HHlHWg1gfkIwG7DRPWcrzF7z4yrzQHCKQ9l2DFdSqp2+9nm0uYNoBbIDhPYGt+EqtvcuIpYeSKx9j2JkAPWTlFBVEefZGwv9tDMFX4ubP/VFYSRZ4eOGg2Ugfh4aLosNbciNMzUsXknMmDgNz3g+vih+USQXmzK2Zwox3FHaieUG5kfdBjAJWEpZyam2DMm3c6jp9cAIsdQeLSHqwLpi9prpIV4wDnHBcVvdIobHWsQUiZC6pANiulTjN6wkc1SZfdYmwq5V036YhvMmiTkf6uByUuoe9La9dfatA3rLwEZ3W3wFvS5y9zBIpKcSUqxYeUjOPNWKFOVjK X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0854; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;20:xGYTQ+2putw6NT26zFPewKQd2LPJHPv6s/dTa8PAmAK6trK5tTLFo//1EnCIPIxnDtk0qtYyRpELO858DgCqp1ZBZZw4zdwsr3uIVP777RNN1+hNuanjTByi5H0qE3SSG6ea+AkyL4NCzBcYLu/JsxIRF1q6Q+MwYRzVN4TWL/kmWYIOAVTI9UDbH8BKbK6GgKEtwONmptn9+pNqu7KAmhXVgRj473wjf4+7QlrOlixpUE0dwYdP2ChHH+0x8LeQ3bChabjz+Sw45cp6YY1X3k+JaoWE+8wzAjs6yLFo6kTBg8z5hUiZiRxi9zblMKKyb+OCfQcjD5UVzv6mW8DS+/KK6NVndyExN9X1+7Aw7Wr4m0CUte6ii9BONJH9Kc2IiqFWFdOdZp5UwO3GSMHi/JkC2Our1LQNWBA2hz024NpuQnBk98w3kPFRy4sBgM4hrDqZQMT0TOzS5x3wtjq0iMDZcp/AusSA/CR3/Z1cJjjEZeKNe8wCGTc9fKdFuEuo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(13015025)(5005006)(13023025)(13024025)(13018025)(8121501046)(3002001)(10201501046);SRVR:CY1PR12MB0854;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0854; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;4:LuSG3R8xx4mXvTiss6heGWgGYr/pialCUr87j9rQm6B1pKeSFMpEKLIzD1Zbxcvx7pzK5rFHdguXGGeK2iQRQWgQDSozh6WnWzz2PzWos8WQut3GwFhHSxcxkHjz6LxexRnuLJRxNpmf5SOlhvyC1rZ/PcGX4oQOk6EOd9zYWqeDLRoZ9pHzx3JjoJM2hcWfSwJoyIoqD1jTA7fNV2MyicOz6GK8b5sjiAEY2whjSAW8gr46Le0THgq9Xz/VwTyntS8fkdW07mz1zFWBAdootL6OPzIIE4fHZwyvnQz/LsreZbyClc6wiHxyBYwUK+VvoEn2IuzqspYdS8BA0UczQHB/W79iBZekpvLV/VFuOGUydFL5dyAefTjaLMA55EKxRzfHVVOgaDEdz+XtFts2TpLi+A4/ndRNQejGJaKscacf+tctq9ko2eagyBMIBSSm85DPdJMaeAJ8gnWn54zVzA== X-Forefront-PRVS: 08831F51DC X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0854;23:oZUMrsyED2FP0iVyA/e7CyA0w7D7QdgrtmtCA?= =?Windows-1252?Q?EZXtUW4W5HuBwpwgixz6k/+NYw/tO3ufb20Lsg+Udp/Rj/iFT3yYUCfx?= =?Windows-1252?Q?93SfVRJnFPQQVXrQJpYGpcI1knqKh/CXPq1aCdydle8OS0ngtEvoAn6P?= =?Windows-1252?Q?oO+xfMz9/cYdJtwETmoIu5R2MJ0+Rs/rMjAgGMGlfJ4apBgQECuEkIxF?= =?Windows-1252?Q?9uniSt0da125f7cPdug7czBMoU+GveevFctYumdbU0GuoQ9k/XqYmskN?= =?Windows-1252?Q?OoIrQNetZW6z5HYHBsxv7GO14yxRw+17B8aIUCK6mpe4+Uztyz4mSSg2?= =?Windows-1252?Q?MRW8bQ9IPsEwiCQu15pPS7uCF+2lodcuqr+3BIwC56rVWkPcCXcXVQD4?= =?Windows-1252?Q?acpegPdUau55DFnZUpKG7Yc4bMQ8TzLN8Se6toGSTfWeweW7IFPK/EC5?= =?Windows-1252?Q?PxD73yGIgU1cM0PdRPNsjxJaJC5yUsNA3nC60FwGYOTTgXZzm6Em3b+u?= =?Windows-1252?Q?lZyD2TfQkTXoFZ2c5hGvZHnoJ+UbcBi0N1OCTTQ2pKSs+gCazxYU1D1B?= =?Windows-1252?Q?gG7XVsc1QUgnA+4V1Msg3LHjrC6wlY9apx26hj9Um14/DsdSMmYryEAB?= =?Windows-1252?Q?vclmU8jwEXboMGhgoe6xD651T9Snm7g2tH3Fnfc2m2CqYYn1HMkIW96H?= =?Windows-1252?Q?zBkcBOncsmiwtfmsGeUMoK7fAF57lLt1V6L67031BT0x8uElPYSDZzla?= =?Windows-1252?Q?8NkoJalftzH751JWxo1FU7az/ffXqfnHkzp84NQFBbOdkUAl2sgVaRyU?= =?Windows-1252?Q?O5RnPNGhSU6qxm6raybgy7MNU0HLR1uteGfCg7MxJpa5d9aA23AL58Fw?= =?Windows-1252?Q?dCztEXB3L1eA2STSOH1wvtX/aaZe8gw8ylyb2RhGY0Ep/Nx6Vw1d9I1/?= =?Windows-1252?Q?Lsip8rQuBYwPVqZoBgCqW28dhXaonh1ZBOsoeHKzYxkX+w5WFv+zI+9r?= =?Windows-1252?Q?XRQ4Yg2oYM+9k+NiPd/jq9yjdF72/f0qndnoHqI9qnw7WERrZF3cqiV3?= =?Windows-1252?Q?sBZnrR3P/DpTi4yWX7QfJm0PMc9WKLnWyv7QvuNnlBeJ+nGQf/CoXzty?= =?Windows-1252?Q?Z77lZfDrsQeYpREwng6um489ckbk87jCxLsQmVEgfYiSEHS+1QGLDcTk?= =?Windows-1252?Q?PnBOBZ7BALCqm6Jm8Os3KKLGgSXEEpPKBxTR5ukPUwUg/35bslKpW6Xj?= =?Windows-1252?Q?cLGvo8xjOcYi10qj+vcog9gtOBU/dd9/5r34I8DNP2LASMNGoOcI90Ym?= =?Windows-1252?Q?6J7sZ/lPHrR/IVJJq2uufEWYA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;5:UiDOeEb6FWwkH/Q99hyqr8NHDGLtLmyJ1vfGVgDjWAih0cWWfe2ElJ8m1H5+Z01O1k0MUhdFvvnNEEXZAIgiswadTa/9tTgncZXiYefhbXJ1RsKCc+/D8shn312tVNvbQr38sONDnpRPdtFFxckSsA==;24:QzwXmwXbEzXQw/WU8Y5HEt2shqHuobTyGO50eoswzJ1j3A7z2nhCfW1KBB1jF3mN5uTsCZVQWuk9VE9fpOu8NSLnbh4xFJQsnyWPCS4RBrY=;20:bhLupEPWFEOlX9s6Re0DKDHSb+HT6f8nIpVLimwQX2UuA0vbjyzkYHN3zqGlrVPjDYRfzqfrkLwPCx6F9TzJA/EfV1RPr9b+qPB53MUhAX6pDqTagpw3U9xiPatNn+d5rdSsjJmHiMEm/k5xzGHU54DEABlQ4uo/Zh8OGvP6xAhzmy5kZ723ZBaNQclssuvYG1ECKTW5t36YTtNAgMhXz5D506p+SD34ke+MvJPcrFrVQDXMID8EBKD6k6lZjpDT SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2016 20:16:05.2656 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0854 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On 01/26/2016 03:36 AM, Hans de Goede wrote: > Hi, > > On 25-01-16 21:43, Tejun Heo wrote: >> On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote: >>> AMD Seattle SATA controller mostly conforms to AHCI interface with some >>> special register to control SGPIO interface. In the case of an AHCI >>> controller, the SGPIO feature is ideally implemented using the >>> "Enclosure Management" register of the AHCI controller, but those >>> registeres are not implemented in the Seattle SoC. Instead SoC >>> (Rev B0 onwards) provides a 32-bit SGPIO control register which should >>> be programmed to control the activity, locate and fault LEDs. >>> >>> The driver is based on ahci_platform driver. >>> >>> Signed-off-by: Brijesh Singh >>> Acked-by: Hans de Goede >>> CC: tj@kernel.org >>> CC: linux-ide@vger.kernel.org >> >> Hans, can you please review the patch? > > Done, driver looks good to me: > > Acked-by: Hans de Goede > Can we please pull this patch ? If needed then I can rebase to the tip. Given the current HW and BIOS limitation, platform driver seems like a right choice. Thanks Brijesh > Regards, > > Hans