From: Babu Moger <babu.moger@oracle.com>
To: mathias.nyman@intel.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers
Date: Wed, 16 Mar 2016 17:26:01 -0500 [thread overview]
Message-ID: <56E9DD79.7010001@oracle.com> (raw)
In-Reply-To: <1452267592-53926-1-git-send-email-babu.moger@oracle.com>
Its been a while since I submit this patch. Ping 1.
On 1/8/2016 9:39 AM, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
>
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> ---
> v2:
> Made changes per comments from Greg KH.
> Extra space removal in assignment
> Added both vendor and device id checks.
>
> drivers/usb/host/pci-quirks.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..0915f44 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1003,6 +1003,14 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
> ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
> } while (1);
>
> + /* Auto handoff never worked for these devices. Force it and continue */
> + if ((pdev->vendor == PCI_VENDOR_ID_TI && pdev->device == 0x8241) ||
> + (pdev->vendor == PCI_VENDOR_ID_RENESAS
> + && pdev->device == 0x0014)) {
> + val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
> + writel(val, base + ext_cap_offset);
> + }
> +
> /* If the BIOS owns the HC, signal that the OS wants it, and wait */
> if (val & XHCI_HC_BIOS_OWNED) {
> writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
>
prev parent reply other threads:[~2016-03-16 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:23 [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers Babu Moger
2016-01-07 17:29 ` Greg KH
2016-01-07 17:51 ` Babu Moger
2016-01-07 18:28 ` Greg KH
2016-01-08 0:04 ` [PATCH v2] " Babu Moger
2016-01-08 1:01 ` Greg KH
2016-01-08 15:36 ` Babu Moger
2016-01-08 15:39 ` Babu Moger
2016-03-16 22:26 ` Babu Moger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9DD79.7010001@oracle.com \
--to=babu.moger@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).