Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

Chanwoo Choi
2016-03-17T01:58:56Z

On 2016년 03월 17일 01:48, Javier Martinez Canillas wrote:
> The driver's Kconfig symbol is a boolean but nothing prevents the driver
> to be built as a module instead of built-in. It is true that most system
> integrators will choose the latter but the config should not restrict it.
>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mfd/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index eea61e349e26..be0ff820621b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -514,8 +514,8 @@ config MFD_88PM860X
> battery-charger under the corresponding menus.
>
> config MFD_MAX14577
> - bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> - depends on I2C=y
> + tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> + depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
>

When I test the kernel build with these patch-set on next-20160316 tag,
the following errors happen.

ERROR: "maxim_charger_calc_reg_current" [drivers/regulator/max14577.ko] undefined!
ERROR: "maxim_charger_currents" [drivers/regulator/max14577.ko] undefined!
ERROR: "maxim_charger_currents" [drivers/power/max14577_charger.ko] undefined!
ERROR: "maxim_charger_calc_reg_current" [drivers/power/max14577_charger.ko] undefined!

Best Regards,
Chanwoo Choi