From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756269AbcCQB64 (ORCPT ); Wed, 16 Mar 2016 21:58:56 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:56625 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756187AbcCQB6y convert rfc822-to-8bit (ORCPT ); Wed, 16 Mar 2016 21:58:54 -0400 X-AuditID: cbfee68e-f793c6d00000136c-13-56ea0f5ae681 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <56EA0F59.4090507@samsung.com> Date: Thu, 17 Mar 2016 10:58:49 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module References: <1458146930-2723-1-git-send-email-javier@osg.samsung.com> <1458146930-2723-3-git-send-email-javier@osg.samsung.com> In-reply-to: <1458146930-2723-3-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsWyRsSkSDeK/1WYwbV1LBZv3q5hsrj/9Sij xeVdc9gcmD3uXNvD5rGl/y67x+dNcgHMUVw2Kak5mWWpRfp2CVwZF9ZfYCyYwVPR0n6TpYFx NlcXIyeHhICJxPH7t1ghbDGJC/fWs3UxcnEICaxglLh3+DYbTNGaXTehEksZJX78+ATWwSsg KPFj8j0WEJtZQF1i0rxFzBC2iMTCYzsZIWxtiWULXzNDND9glOjfNpEZollL4sejO2A2i4Cq xPSr18GGsgHF97+4AbSNg0NUIEKi+0QlSFhEIFTi38XbUDNVJHZ/OcEOUiIsECaxeq8yxPhG Ronl5/rA7uEUcJOY29HKApKQEFjGLvHkxEUWiF0CEt8mH2IBaZYQkJXYdIAZ4klJiYMrbrBM YBSfheS1WUhem4XktVlIXlvAyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIzDWTv971reD 8eYB60OMAhyMSjy8DOdehgmxJpYVV+YeYjQFumgis5Rocj4wovNK4g2NzYwsTE1MjY3MLc2U xHkTpH4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamDk49G07DCVvRqmtrtfjq9J4NezhslH PLds2PBesp5HzW/CS8lXq8x3SRnF7wu6e8Y4Q9L3UI6NFMcHtvP/8vpOt35d0Nky8ULLeiGv I3473fIEuO9t9VPoTWkwaWC5Nil3X1Jp86P8lsaXkWvXHT4//zzP7k/qYp11VYXzstTXOLGw MVzeLarEUpyRaKjFXFScCACBR5qRsAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t9jAd1I/ldhBnfv2Fi8ebuGyeL+16OM Fpd3zWFzYPa4c20Pm8eW/rvsHp83yQUwRzUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY 6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVJSKEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdj ZIAGEtYwZmxatYqtoIWn4uPhR6wNjO1cXYycHBICJhJrdt1kg7DFJC7cWw9kc3EICSxllPjx 4xMrSIJXQFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/4BRon/bRGaIei2JH4/ugNks AqoS069eB5vDBhTf/+IGG8gcUYEIie4TlSBhEYFQiX8XbzNCzFSR2P3lBDtIibBAmMTqvcoQ 4xsZJZaf62MBqeEUcJOY29HKMoFRYBaS62YhXDcLyXULGJlXMUqkFiQXFCel5xrmpZbrFSfm Fpfmpesl5+duYgTH5jOpHYwHd7kfYhTgYFTi4V1x+mWYEGtiWXFl7iFGCQ5mJRFepaNAId6U xMqq1KL8+KLSnNTiQ4ymQO9NZJYSTc4Hpo28knhDYxMzI0sjc0MLI2NzJXHex//XhQkJpCeW pGanphakFsH0MXFwSjUwKnxgmhjHL3r54PGlrr/OHKhM+dJRuEbthueG7Sk9F8T1rrlaV1+8 02ueIiIV+V1Q1z5+1oaSOd+N3d/F99/bli29MXTZirYGJv6cp5q/Q/n7ogS/LVwbdnH1Q0HV eQmHva2sK9tPmzc8npJ8eidzY8bOKCZ11htzTzn58oaUx/r9/l5f0WmqxFKckWioxVxUnAgA KMpNjeMCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 03월 17일 01:48, Javier Martinez Canillas wrote: > The driver's Kconfig symbol is a boolean but nothing prevents the driver > to be built as a module instead of built-in. It is true that most system > integrators will choose the latter but the config should not restrict it. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index eea61e349e26..be0ff820621b 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -514,8 +514,8 @@ config MFD_88PM860X > battery-charger under the corresponding menus. > > config MFD_MAX14577 > - bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" > - depends on I2C=y > + tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" > + depends on I2C > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > When I test the kernel build with these patch-set on next-20160316 tag, the following errors happen. ERROR: "maxim_charger_calc_reg_current" [drivers/regulator/max14577.ko] undefined! ERROR: "maxim_charger_currents" [drivers/regulator/max14577.ko] undefined! ERROR: "maxim_charger_currents" [drivers/power/max14577_charger.ko] undefined! ERROR: "maxim_charger_calc_reg_current" [drivers/power/max14577_charger.ko] undefined! Best Regards, Chanwoo Choi