From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030613AbcCRAIF (ORCPT ); Thu, 17 Mar 2016 20:08:05 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:14410 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967113AbcCRAH7 (ORCPT ); Thu, 17 Mar 2016 20:07:59 -0400 X-AuditID: cbfec7f5-f79b16d000005389-bb-56eb46dbd629 Subject: Re: [PATCH] regulator: Rename files for Maxim PMIC drivers To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1458237294-13730-1-git-send-email-javier@osg.samsung.com> Cc: Liam Girdwood , Chanwoo Choi , Mark Brown From: Krzysztof Kozlowski Message-id: <56EB46D7.5030807@samsung.com> Date: Fri, 18 Mar 2016 09:07:51 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1458237294-13730-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xa7q33V6HGTTdNbOY+vAJm8X1L89Z Ld68XcNk8fqFocW3Kx1MFpd3zWFzYPPYOesuu8emVZ1sHlv6gay+LasYPT5vkgtgjeKySUnN ySxLLdK3S+DKWNy+mK3gPH/Fpx9H2BsYt/N0MXJySAiYSKybP5cRwhaTuHBvPVsXIxeHkMBS RokvZ66yQzhPGSWebJnJBlIlLOAssW7fTnYQW0QgVOLfxdtA3RxARW4Sq06Jg4SZBQokDs+b D1bCJmAssXn5ErBWXgEtiZZ/i5hAbBYBVYkjm2aD2aICERJP5p5khKgRlPgx+R4LiM0p4C6x YdYpJpDxzAJ6EvcvakGMl5fYvOYt8wRGgVlIOmYhVM1CUrWAkXkVo2hqaXJBcVJ6rpFecWJu cWleul5yfu4mRkhQf93BuPSY1SFGAQ5GJR5ehnMvw4RYE8uKK3MPMUpwMCuJ8Ca6vg4T4k1J rKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA+OaOTxzv16PSpqQ 8rFgV5Zq38fH0Q8DrDjrLI8v+X97lU7zEZXXTwzqJRLc8spUD/V2Sf9OEd2ksUFHSVgttVzC Ivjuq0LBf4J/Fm5+9Pp1Ovfq/mt8Xluvz98WtX9GOqvKPrFlKyWjNi1I+zTR8pujbHsq0/0p blVPFq25nlPJxXDa2vqyYZgSS3FGoqEWc1FxIgAttzmaZgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.03.2016 02:54, Javier Martinez Canillas wrote: > Most Maxim PMIC regulator drivers are for sub-devices of Multi-Function > Devices with drivers under drivers/mfd. But for many of these, the same > object file name was used for both the MFD and the regulator drivers. > > Having 2 different drivers with the same name causes a lot of confusion > to Kbuild, specially if these are built as module since only one module > will be installed and also exported symbols will be undefined due being > overwritten by the other module during modpost. These regulator drivers do not export symbols. In case of max14577 only main MFD driver exports symbols so what do you mean by "overwriting by other module"? Beside that comment the patch itself is okay: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > For example, it fixes the following issue when both drivers are module: > > $ make M=drivers/regulator/ > ... > CC [M] drivers/regulator//max14577.o > Building modules, stage 2. > MODPOST 1 modules > WARNING: "maxim_charger_calc_reg_current" [drivers/regulator//max14577.ko] undefined! > WARNING: "maxim_charger_currents" [drivers/regulator//max14577.ko] undefined! > > Reported-by: Chanwoo Choi > Signed-off-by: Javier Martinez Canillas > > --- > > MAINTAINERS | 4 ++-- > drivers/regulator/Makefile | 6 +++--- > drivers/regulator/{max14577.c => max14577-regulator.c} | 0 > drivers/regulator/{max77693.c => max77693-regulator.c} | 0 > drivers/regulator/{max8997.c => max8997-regulator.c} | 0 > 5 files changed, 5 insertions(+), 5 deletions(-) > rename drivers/regulator/{max14577.c => max14577-regulator.c} (100%) > rename drivers/regulator/{max77693.c => max77693-regulator.c} (100%) > rename drivers/regulator/{max8997.c => max8997-regulator.c} (100%) >