From: Chanwoo Choi <cw00.choi@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] regulator: Rename files for Maxim PMIC drivers
Date: Fri, 18 Mar 2016 09:31:03 +0900 [thread overview]
Message-ID: <56EB4C47.4060604@samsung.com> (raw)
In-Reply-To: <1458237294-13730-1-git-send-email-javier@osg.samsung.com>
Hi Javier,
On 2016년 03월 18일 02:54, Javier Martinez Canillas wrote:
> Most Maxim PMIC regulator drivers are for sub-devices of Multi-Function
> Devices with drivers under drivers/mfd. But for many of these, the same
> object file name was used for both the MFD and the regulator drivers.
>
> Having 2 different drivers with the same name causes a lot of confusion
> to Kbuild, specially if these are built as module since only one module
> will be installed and also exported symbols will be undefined due being
> overwritten by the other module during modpost.
>
> For example, it fixes the following issue when both drivers are module:
>
> $ make M=drivers/regulator/
> ...
> CC [M] drivers/regulator//max14577.o
> Building modules, stage 2.
> MODPOST 1 modules
> WARNING: "maxim_charger_calc_reg_current" [drivers/regulator//max14577.ko] undefined!
> WARNING: "maxim_charger_currents" [drivers/regulator//max14577.ko] undefined!
>
> Reported-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Best Regards,
Chanwoo Choi
[snip]
prev parent reply other threads:[~2016-03-18 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 17:54 [PATCH] regulator: Rename files for Maxim PMIC drivers Javier Martinez Canillas
2016-03-18 0:07 ` Krzysztof Kozlowski
2016-03-18 2:41 ` Javier Martinez Canillas
2016-03-18 3:29 ` Krzysztof Kozlowski
2016-03-18 0:31 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EB4C47.4060604@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox