From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967442AbcCRAbM (ORCPT ); Thu, 17 Mar 2016 20:31:12 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60959 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcCRAbG (ORCPT ); Thu, 17 Mar 2016 20:31:06 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79646d000001316-7f-56eb4c471dba Content-transfer-encoding: 8BIT Message-id: <56EB4C47.4060604@samsung.com> Date: Fri, 18 Mar 2016 09:31:03 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Liam Girdwood , Krzysztof Kozlowski , Mark Brown Subject: Re: [PATCH] regulator: Rename files for Maxim PMIC drivers References: <1458237294-13730-1-git-send-email-javier@osg.samsung.com> In-reply-to: <1458237294-13730-1-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsWyRsSkWNfd53WYwenHKhZTHz5hs3jzdg2T xesXhhbfrnQwWVzeNYfNgdVj56y77B6bVnWyeWzpB7L6tqxi9Pi8SS6ANYrLJiU1J7MstUjf LoErY8+6JraCZZwVN+YsZ2tgvMTexcjJISFgIvHuaTsbhC0mceHeejBbSGAFo8TfB4kwNY+v fmbtYuQCii9llFj5bTpYM6+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGaL+AaPEp2fX mSDqtSTOtv5jBLFZBFQldk58AhZnA4rvf3GDDWSOqECERPeJSpCwiECoxL+LtxkhxldKzOkJ BwkLCzhLrNu3kx0kLCTgJrHqlDhImFPAXWLDrFNMIFslBA6xS5zbOYsNYpOAxLfJh8CulBCQ ldh0gBniK0mJgytusExgFJuF5JdZCL/MQvLLAkbmVYyiqQXJBcVJ6UUmesWJucWleel6yfm5 mxiBcXX637MJOxjvHbA+xCjAwajEw7vy9MswIdbEsuLK3EOMpkBHTGSWEk3OB0ZvXkm8obGZ kYWpiamxkbmlmZI472upn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGOMefl76xnbO1tji gyumvmCrY639bMtR+pBRPvLuj/frIhq7nGubv/xkPD2jRfJJcd2C633iwSx8u80vBE8te+nD tVW3T6Zq25zk7+dOul2a0ceUyqzje/XM22ua10QMmmoCsuZ77+oUn6/zTVnt463QzXpT2cMZ 0q0uiPgeztHZIfnl96/nZ5RYijMSDbWYi4oTAfhJpJmmAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jAV13n9dhBu3/5S2mPnzCZvHm7Rom i9cvDC2+Xelgsri8aw6bA6vHzll32T02repk89jSD2T1bVnF6PF5k1wAa1QDo01GamJKapFC al5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0HIlhbLEnFKgUEBicbGS vh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8aedU1sBcs4K27MWc7WwHiJvYuRk0NCwETi8dXP rBC2mMSFe+vZuhi5OIQEljJKrPw2HayIV0BQ4sfkeyxdjBwczALyEkcuZYOEmQXUJSbNW8QM Uf+AUeLTs+tMEPVaEmdb/zGC2CwCqhI7Jz4Bi7MBxfe/uMEGMkdUIEKi+0QlSFhEIFTi38Xb jBDjKyXm9ISDhIUFnCXW7dvJDhIWEnCTWHVKHCTMKeAusWHWKaYJjAKzkNw2C+G2WUhuW8DI vIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOHqfSe1gPLjL/RCjAAejEg/vitMvw4RY E8uKK3MPMUpwMCuJ8DJ7vw4T4k1JrKxKLcqPLyrNSS0+xGgK9NxEZinR5HxgYskriTc0NjEz sjQyN7QwMjZXEud9/H9dmJBAemJJanZqakFqEUwfEwenVANjOdv3A/zNiU8X6p3y3hXLdiDp TmJqKLvhHH+7b3kH66/Vvl9zUX2H1tOJdcblsncXVSaETVjpPPn2RY4Eg0mz8552P31kPb9U 6JBJsfyPPJmSm7Xppd6Lk7iePen4ee3ClRu5mdnRHnsTzErvFrqeYlyQd6vvAYsr+/5c3YtS 77iuXnV0tnFRYinOSDTUYi4qTgQAt0KuTfQCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On 2016년 03월 18일 02:54, Javier Martinez Canillas wrote: > Most Maxim PMIC regulator drivers are for sub-devices of Multi-Function > Devices with drivers under drivers/mfd. But for many of these, the same > object file name was used for both the MFD and the regulator drivers. > > Having 2 different drivers with the same name causes a lot of confusion > to Kbuild, specially if these are built as module since only one module > will be installed and also exported symbols will be undefined due being > overwritten by the other module during modpost. > > For example, it fixes the following issue when both drivers are module: > > $ make M=drivers/regulator/ > ... > CC [M] drivers/regulator//max14577.o > Building modules, stage 2. > MODPOST 1 modules > WARNING: "maxim_charger_calc_reg_current" [drivers/regulator//max14577.ko] undefined! > WARNING: "maxim_charger_currents" [drivers/regulator//max14577.ko] undefined! > > Reported-by: Chanwoo Choi > Signed-off-by: Javier Martinez Canillas Reviewed-by: Chanwoo Choi Best Regards, Chanwoo Choi [snip]