Re: [PATCH] regulator: Rename files for Maxim PMIC drivers

Krzysztof Kozlowski
2016-03-18T00:08:05Z

On 18.03.2016 02:54, Javier Martinez Canillas wrote:
> Most Maxim PMIC regulator drivers are for sub-devices of Multi-Function
> Devices with drivers under drivers/mfd. But for many of these, the same
> object file name was used for both the MFD and the regulator drivers.
>
> Having 2 different drivers with the same name causes a lot of confusion
> to Kbuild, specially if these are built as module since only one module
> will be installed and also exported symbols will be undefined due being
> overwritten by the other module during modpost.

These regulator drivers do not export symbols. In case of max14577 only
main MFD driver exports symbols so what do you mean by "overwriting by
other module"?

Beside that comment the patch itself is okay:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,

Krzysztof

>
> For example, it fixes the following issue when both drivers are module:
>
> $ make M=drivers/regulator/
> ...
> CC [M] drivers/regulator//max14577.o
> Building modules, stage 2.
> MODPOST 1 modules
> WARNING: "maxim_charger_calc_reg_current" [drivers/regulator//max14577.ko] undefined!
> WARNING: "maxim_charger_currents" [drivers/regulator//max14577.ko] undefined!
>
> Reported-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> MAINTAINERS | 4 ++--
> drivers/regulator/Makefile | 6 +++---
> drivers/regulator/{max14577.c => max14577-regulator.c} | 0
> drivers/regulator/{max77693.c => max77693-regulator.c} | 0
> drivers/regulator/{max8997.c => max8997-regulator.c} | 0
> 5 files changed, 5 insertions(+), 5 deletions(-)
> rename drivers/regulator/{max14577.c => max14577-regulator.c} (100%)
> rename drivers/regulator/{max77693.c => max77693-regulator.c} (100%)
> rename drivers/regulator/{max8997.c => max8997-regulator.c} (100%)
>