From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcCRDaE (ORCPT ); Thu, 17 Mar 2016 23:30:04 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:16302 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbcCRD35 (ORCPT ); Thu, 17 Mar 2016 23:29:57 -0400 X-AuditID: cbfec7f5-f79b16d000005389-2b-56eb7631d6e6 Subject: Re: [PATCH] regulator: Rename files for Maxim PMIC drivers To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1458237294-13730-1-git-send-email-javier@osg.samsung.com> <56EB46D7.5030807@samsung.com> <56EB6AD6.7050407@osg.samsung.com> Cc: Liam Girdwood , Chanwoo Choi , Mark Brown From: Krzysztof Kozlowski Message-id: <56EB762D.9070200@samsung.com> Date: Fri, 18 Mar 2016 12:29:49 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <56EB6AD6.7050407@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t/xq7qGZa/DDPbtV7aY+vAJm8X1L89Z Ld68XcNk8fqFocW3Kx1MFpd3zWFzYPPYOesuu8emVZ1sHlv6gay+LasYPT5vkgtgjeKySUnN ySxLLdK3S+DKaH9+gblgJm/FmUWLGRsYT3B1MXJwSAiYSFy6wdHFyAlkiklcuLeerYuRi0NI YCmjxN2VPcwQzlNGiRX/1zGBVAkLOEus27eTHcQWEQiV+HfxNiNEURejxP6Pa1hBEswCBRKH 580HK2ITMJbYvHwJG4jNK6Al0fXpOFicRUBVYuKMJSwgtqhAhMSTuScZIWoEJX5MvgcW5xTQ l7h2fwUjyKXMAnoS9y9qQYyXl9i85i3zBEaBWUg6ZiFUzUJStYCReRWjaGppckFxUnqukV5x Ym5xaV66XnJ+7iZGSFh/3cG49JjVIUYBDkYlHl6Gcy/DhFgTy4orcw8xSnAwK4nwsoW/DhPi TUmsrEotyo8vKs1JLT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKYLBMHp1QDY9TCBSV70iqW PWF3MzZtK0xzm+VYrB5j7+8ybaINF4Prm11SjxkvpG+96pSmo2a181634rPdDvd9Hb52SLGu /q1Xq8C+lWO/iorczRM/l+5n0BbIjPY55+kUI8Eo+11/13LZuNt9h/zWfp6guShLccW3U3d0 Gz9svZN7TuLiZNP/kRExn4rPKbEUZyQaajEXFScCAEoZrtpnAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.03.2016 11:41, Javier Martinez Canillas wrote: > Hello Krzysztof, > > Thanks a lot for your review. > > On 03/17/2016 09:07 PM, Krzysztof Kozlowski wrote: >> On 18.03.2016 02:54, Javier Martinez Canillas wrote: >>> Most Maxim PMIC regulator drivers are for sub-devices of Multi-Function >>> Devices with drivers under drivers/mfd. But for many of these, the same >>> object file name was used for both the MFD and the regulator drivers. >>> >>> Having 2 different drivers with the same name causes a lot of confusion >>> to Kbuild, specially if these are built as module since only one module >>> will be installed and also exported symbols will be undefined due being >>> overwritten by the other module during modpost. >> >> These regulator drivers do not export symbols. In case of max14577 only >> main MFD driver exports symbols so what do you mean by "overwriting by >> other module"? >> > > That's correct, what I meant is that if only the MFD driver is built, then > Kbuild / modpost are able to obtain the exported symbols and add it to the > Module.symvers file. > > But if the regulator driver is also built, then the build system isn't able > to handle that case and the exported symbols from Module.symvers disappear. > > So IIUC what happens is that the build system gets the exported symbols from > the max14755 MFD module but then finds another module that has the same name > (with no exported symbols) and so discards the list of symbols that previously > had for that module. That's why I used the "overwriting by the other module". Ah, that indeed makes sense. Thanks for careful explanation. Best regards, Krzysztof