From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752124AbcCRHze (ORCPT ); Fri, 18 Mar 2016 03:55:34 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:50494 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbcCRHzZ convert rfc822-to-8bit (ORCPT ); Fri, 18 Mar 2016 03:55:25 -0400 X-AuditID: cbfee690-f79646d000001316-f8-56ebb46b08f0 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <56EBB46B.9000503@samsung.com> Date: Fri, 18 Mar 2016 16:55:23 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module References: <1458146930-2723-1-git-send-email-javier@osg.samsung.com> <1458146930-2723-3-git-send-email-javier@osg.samsung.com> <56EA0F59.4090507@samsung.com> <56EACF40.8090609@osg.samsung.com> <56EAE1E4.10202@osg.samsung.com> <56EAF128.8050709@osg.samsung.com> In-reply-to: <56EAF128.8050709@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsWyRsSkWDd7y+swg4V9vBZv3q5hsrj/9Sij xeVdc9gcmD3uXNvD5rGl/y67x+dNcgHMUVw2Kak5mWWpRfp2CVwZV7+2shYs4KrYtqKHpYGx m6OLkZNDQsBEYv+DycwQtpjEhXvr2boYuTiEBFYwSvyadJcZpmjqzb/MEImljBKHjh1kBEnw CghK/Jh8j6WLkYODWUBdYsqUXJAws4CIxPwtFxkhbG2JZQtfQ/U+YJRonbOYHaJXS2L1/oVM IDaLgKrEseczwZaxAcX3v7jBBjJTVCBCovtEJUhYRCBU4t/F21AzVSR2fznBDlIiLBAmsXqv MsT4biaJS+93gtVwCuhLNM+/zwKSkBBYxi4xfesZNohdAhLfJh8Cu1lCQFZi0wGoHyUlDq64 wTKBUXwWks9mIXw2C8lns5B8toCRZRWjaGpBckFxUnqRiV5xYm5xaV66XnJ+7iZGYJyd/vds wg7GewesDzEKcDAq8fBOrHgdJsSaWFZcmXuI0RTooInMUqLJ+cBoziuJNzQ2M7IwNTE1NjK3 NFMS530t9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2PKkyPbbfo3lt++08oiWRhsznfF e9vmP2ufitXu8bhl53/ZICvs7JnTr59cin03yXUqu3jj5IRbFlVPb2z6E6F2jHnXUVW/v4ss 3/D53nn97WW1WgxLYEy0jfCxrxtqFHW1BX6veH7V5dafUyevx8l+5BM7/PrTIYWNSlWrz9St fHdlbUXV5YeKSizFGYmGWsxFxYkAVeSQwK4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t9jAd3sLa/DDNac57B483YNk8X9r0cZ LS7vmsPmwOxx59oeNo8t/XfZPT5vkgtgjmpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw 1DW0tDBXUshLzE21VXLxCdB1y8wB2qSkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7H yAANJKxhzHi/Oqugh6vi0voe9gbG7+xdjJwcEgImElNv/mWGsMUkLtxbz9bFyMUhJLCUUeLQ sYOMIAleAUGJH5PvsXQxcnAwC8hLHLmUDWGqS0yZkgtR/oBRonXOYnaIci2J1fsXMoHYLAKq EseezwSbzwYU3//iBhtIr6hAhET3iUqQsIhAqMS/i7fBNjELqEjs/nKCHaREWCBMYvVeZYjx 3UwSl97vBKvhFNCXaJ5/n2UCo8AsJMfNQjhuFsJxCxiZVzFKpBYkFxQnpeca5qWW6xUn5haX 5qXrJefnbmIER+UzqR2MB3e5H2IU4GBU4uGdUPE6TIg1say4MvcQowQHs5IIL2cbUIg3JbGy KrUoP76oNCe1+BCjKdB3E5mlRJPzgQkjryTe0NjEzMjSyNzQwsjYXEmc9/H/dWFCAumJJanZ qakFqUUwfUwcnFINjMLVGScXcL5vsqr93Hvv1cXzYr7Bkzd93VD69o2gFJ9l1IW0pL9LlH8c cwv3PhKs1HX0Zb+Ku//qCQpdZWtjLfUPnOyYw3uJd2vht72sV0xbtJbOuff53pVlrvf7NkrK HHU8d8ziPa8dc+Ojn4k3qvW2PjyfJ+2UN0+t7Hf/qn/sq2YZBdcq1iqxFGckGmoxFxUnAgA3 u/DI4AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Javier, On 2016년 03월 18일 03:02, Javier Martinez Canillas wrote: > Hello Chanwoo > > On 03/17/2016 01:57 PM, Javier Martinez Canillas wrote: > > [snip] > >>> >> >> Sorry again, this error goes away after I clean the build directory so it >> does not happen without this patch-set. Now, I found what's the issue and >> is that both the max14577 MFD and regulator drivers have the same object >> file name so they both end being called max14577.ko. >> >> This confuses Kbuild and so in the modpost step, the exported symbols by >> the MFD driver don't end into Module.symvers. This doesn't happen when >> the driver is not a module since symbols come from the vmlinux binary. >> >> I'll post a patch to rename the regulator driver to max14577-regulator, >> this will be necessary anyways to have max14577 as a module since Kbuild >> also gets confused and don't copy both modules because have the same name. >> > > Patch is [0], could you please test the patch-series along with that one > and provide your Tested-by? I plan to re-send this series once [0] lands. I'll test it on next week and then reply. Best Regards, Chanwoo Choi > >> Best regards, >> > > [0]: https://patchwork.kernel.org/patch/8613691/ > > Best regards, >