From: Lu Baolu <baolu.lu@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver
Date: Fri, 18 Mar 2016 16:43:21 +0800 [thread overview]
Message-ID: <56EBBFA9.30101@linux.intel.com> (raw)
In-Reply-To: <20160318080924.GD13692@x1>
On 03/18/2016 04:09 PM, Lee Jones wrote:
> On Fri, 18 Mar 2016, Lu Baolu wrote:
>
>> Some Intel platforms have an USB port mux controlled by GPIOs.
>> There's a single ACPI platform device that provides both USB ID
>> extcon device and a USB port mux device. This MFD driver will
>> split the 2 devices for their respective drivers.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Suggested-by: David Cohen <david.a.cohen@linux.intel.com>
> This should be at the top.
>
> You couldn't have written the patch before it was suggested.
Yes. I will change this.
>
>> Reviewed-by: Felipe Balbi <balbi@kernel.org>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> What is this sign-off meant to indicate?
Fengguang's sign-off was added due to folding a patch contributed by
his kbuild robot.
https://lkml.org/lkml/2016/3/3/118
I will add this in commit message.
>
>> Reviewed-by: Lee Jones <lee.jones@linaro.org>
> Why is this here?
>
> a) I don't provide "Reviewed-by:" tags #alarmbells
> b) I have never signed this patch off
Sorry about this. I will remove this line.
>
>> ---
>> MAINTAINERS | 6 ++++
> Seperate patch.
If I make it in a separate patch, checkpatch.pl will give me below warning.
"
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51:
new file mode 100644
"
Is it forgivable?
Best regards,
Baolu
>
>> drivers/mfd/Kconfig | 8 +++++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/intel-vuport.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 89 insertions(+)
>> create mode 100644 drivers/mfd/intel-vuport.c
> [...]
>
next prev parent reply other threads:[~2016-03-18 8:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 6:32 [PATCH v5 0/6] usb: add support for Intel dual role port mux Lu Baolu
2016-03-18 6:32 ` [PATCH v5 1/6] extcon: usb-gpio: add device binding for platform device Lu Baolu
2016-03-18 6:32 ` [PATCH v5 2/6] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu
2016-03-18 6:32 ` [PATCH v5 3/6] usb: mux: add common code for Intel dual role port mux Lu Baolu
2016-03-18 7:52 ` Chanwoo Choi
2016-03-18 8:23 ` Lu Baolu
2016-03-18 6:32 ` [PATCH v5 4/6] usb: mux: add driver for Intel gpio controlled " Lu Baolu
2016-03-18 6:32 ` [PATCH v5 5/6] usb: mux: add driver for Intel drcfg " Lu Baolu
2016-03-18 6:32 ` [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-03-18 8:09 ` Lee Jones
2016-03-18 8:43 ` Lu Baolu [this message]
2016-03-18 15:30 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBBFA9.30101@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=balbi@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox